Skip to content

Remove emitEmpty option in .bufferWhileBy #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rpominov opened this issue Aug 18, 2015 · 1 comment
Closed

Remove emitEmpty option in .bufferWhileBy #131

rpominov opened this issue Aug 18, 2015 · 1 comment
Labels
breaking

Comments

@rpominov
Copy link
Member

There is an inconsistency between two — one emits empty arrays by default other has option emitEmpty.

Also perhaps a lot of options make it hard to understand how it works https://github.com/rpominov/kefir/pull/129#issuecomment-131449876

Related: #128 #129 #108

The emitEmpty option from .bufferWhileBy removed, it now always emits [] if necessary.

Migration

(needed only if your code requires the array not to be empty)

Before After
foo.bufferWhileBy(bar) foo.bufferWhileBy(bar).filter(x => x.length > 0)
@rpominov rpominov added this to the v3.0.0 milestone Aug 18, 2015
@rpominov rpominov mentioned this issue Sep 3, 2015
Closed
9 tasks
@rpominov
Copy link
Member Author

rpominov commented Sep 5, 2015

We should remove emitEmpty option from .bufferWhileBy and make it emit empty arrays if necessary like .bufferBy does.

@rpominov rpominov changed the title Polish API of .bufferBy & .bufferWhileBy Remove emitEmpty option in .bufferWhileBy Sep 5, 2015
@rpominov rpominov removed this from the v3.0.0 milestone Sep 19, 2015
rpominov added a commit that referenced this issue Sep 26, 2015
@rpominov
Merge branch 'master' into gh-pages
3a4c92f 
* master: (26 commits)
  cleanup repository after release
  3.0.0
  cleanup repository after release
  3.0.0-rc.0
  fix link in changelog
  update changelog
  rename .skipValues() and friends to .ignoreValues()
  reorder methods in docs
  remove valuesToErrors from examples in docs
  add link to 2.x version in deprecated-api-docs.md
  update changelog
  update changelog
  add .takeErrors docs #150
  move deprecated method docs to separate file
  add deprecation warnings for 3.0 deprecations
  make .flatten always return a stream (fixes #144)
  remove emitEmpty option in .bufferWhileBy (fixes #131)
  add .takeErrors (no docs yet) #150
  remove deprecated methods (test)
  remove deprecated methods (docs)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpominov