Skip to content

BufferWhileBy should emit empty array if primary source finished first #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shamansir opened this issue Aug 14, 2015 · 2 comments
Closed

BufferWhileBy should emit empty array if primary source finished first #128

shamansir opened this issue Aug 14, 2015 · 2 comments
Labels
enhancement

Comments

@shamansir
Copy link
Contributor

BufferWhileBy should emit empty array if primary source finished (without any value) before the secondary one.
shamansir added a commit to shamansir/kefir that referenced this issue Aug 14, 2015
@shamansir
bufferWhileBy: emit empty array when primary source finished first (k…
a0a0ad7 
…efirjs#128)
@shamansir
Copy link
Contributor Author

Could be related to #113

@shamansir shamansir mentioned this issue Aug 14, 2015
Merged
rpominov added a commit that referenced this issue Aug 17, 2015
@rpominov
Merge pull request #129 from shamansir/master
bd0f66f 
BufferWhileBy: emit empty array when primary source finished first (#128)
@rpominov
Copy link
Member

Fixed by #129

@rpominov rpominov mentioned this issue Aug 18, 2015
Closed
rpominov added a commit that referenced this issue Aug 21, 2015
@rpominov
Merge branch 'master' into gh-pages
0cdbd04 
* master:
  cleanup repository after release
  2.8.0
  update deps
  update changelog
  more clear docs on options of .bufferWhileBy (hopefully)
  improve bufferWhileBy test
  fix test title for bufferWhileBy test
  fix bufferWhileBy test for empty buffer w/ flushOnChange, emitEmpty, p.2
  fix bufferWhileBy description, test bufferWhileBy for flushOnChange/emitEmpty
  emitEmpty as an option for bufferWhileBy
  bring back empty lines
  bufferWhileBy: emit empty array when primary source finished first (#128)
  Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shamansir @rpominov