[breaking] deprecate dnsZone and edgeDnsZone chart values #1876

abaguas · 2025-04-02T15:36:10Z

PR #1845 introduced the possibility to configure multiple DNS zones. The intention was to be backwards compatible. However it forces uses to change the new helm values, as explained in #1858.

The naming of zones was also reviewed, since edgeZone was not very clear. So the change is as follows:

k8gb.dnsZoneNegTTL -> k8gb.dnsZones[0].dnsZoneNegTTL
k8gb.edgeDnsZone -> k8gb.dnsZones[0].parentZone
k8gb.dnsZone -> k8gb.dnsZones[0].loadBalancedZone

During the community meeting of 02.04.2025 it was agreed to maintain the breaking change and clean up the deprecated values configuration.

Fixes #1858

netlify · 2025-04-02T15:37:47Z

✅ Deploy Preview for k8gb-preview ready!

Name	Link
🔨 Latest commit	`3eb8828`
🔍 Latest deploy log	https://app.netlify.com/sites/k8gb-preview/deploys/6824dfa23da9d4000898a0ea
😎 Deploy Preview	https://deploy-preview-1876--k8gb-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

abaguas · 2025-04-02T15:41:24Z

@kuritka can we rediscuss the new naming of the options?

edgeDnsZone -> zone (example.com)
dnsZone -> domain (cloud.example.com)

What is for you the different between zone and domain?
If I consider domain as an fqdn then "cloud.example.com" is not an fqdn. The fqdn will be "app.cloud.example.com".
If I consider domain as a portion of an fqdn then it is the same as zone.

Can you explain your reasoning for the change? What was confusing with the previous naming?

kuritka · 2025-04-02T16:27:44Z

Hey, totally valid question – both naming schemes actually make sense.

I renamed edgeDnsZone -> zone and dnsZone -> domain mainly to make the hierarchy clearer and more intuitive for users configuring it:

zone is the top-level (e.g. example.com)

domain is a sub-part of it (e.g. cloud.example.com)

You're right that technically both are zones, and using edgeDnsZone / dnsZone is more DNS-accurate.
But the old naming was a bit hard to read without knowing the internal distinction between "edge" and "non-edge".

Happy to revisit if we find better names that keep both clarity and accuracy – e.g. rootZone / subZone could be a compromise. Why do you feel such a need to change it?

abaguas · 2025-04-03T15:23:13Z

I agree edge zone is not very clear.

Why do you feel such a need to change it?

I feel calling domain to one of the zones will also lead to confusion. So, since we changed it we can get it 100% accurate before the upcoming release.

Root zone is the zone controlled by the root servers. But I like the idea of hierarchy it brings. What do you think about "zone"/"k8gbZone"/"delegatedZone" and "parentZone"?

kuritka · 2025-04-07T09:07:55Z

Root zone is the zone controlled by the root servers. But I like the idea of hierarchy it brings. What do you think about "zone"/"k8gbZone"/"delegatedZone" and "parentZone"?

apart k8gbZone (which, anyone can interpret differently) im fine with all of them. thx! 👍

Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>

ytsarev

Overall LGTM. Added couple of comments
We will have to work on next release notes explicitly mentioning that change

ytsarev · 2025-04-20T22:03:20Z

chart/k8gb/values.yaml

-    - zone: "example.com" # -- main zone which would contain gslb zone to delegate (same meaning as to edgeDNSZone)
-      domain: "cloud.example.com" # -- domain controlled by gslb (same meaning as to dnsZone)
+    - parentZone: "example.com" # -- parent zone which would contain gslb zone to delegate (same meaning as to edgeDNSZone)
+      zone: "cloud.example.com" # -- zone controlled by gslb (same meaning as to dnsZone)


Maybe loadBalancedZone to be explicit?

Sounds good to me. @kuritka?

Changed done here: 3d02437

ytsarev · 2025-04-20T22:04:05Z

chart/k8gb/values.schema.json

+            "required": [
+                "clusterGeoTag",
+                "extGslbClustersGeoTags",
+                "edgeDNSServers",


We need to change this terminology too to be consistent

Thanks, good catch
36382b7

kuritka

thx @abaguas

Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>

PR k8gb-io#1845 introduced the possibility to configure multiple DNS zones. The intention was to be backwards compatible. However it forces uses to change the following helm values, as explained in k8gb-io#1858: * k8gb.dnsZoneNegTTL -> k8gb.dnsZones[0].dnsZoneNegTTL * k8gb.edgeDnsZone -> k8gb.dnsZones[0].zone * k8gb.dnsZone -> k8gb.dnsZones[0].domain During the community meeting of 02.04.2025 it was agreed to maintain the breaking change and clean up the deprecated values configuration. Fixes k8gb-io#1858 Signed-off-by: Andre Aguas <[email protected]>

Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>

Signed-off-by: Andre Aguas <[email protected]>

abaguas added a commit to abaguas/k8gb that referenced this pull request Apr 7, 2025

rename domain -> zone; zone -> parentZone

90d58d5

Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>

abaguas added a commit to abaguas/k8gb that referenced this pull request Apr 7, 2025

rename domain -> zone; zone -> parentZone

c8dc2a7

Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>

abaguas force-pushed the dnszones/breakingchange branch from 90d58d5 to c8dc2a7 Compare April 7, 2025 16:28

abaguas added a commit to abaguas/k8gb that referenced this pull request Apr 7, 2025

rename domain -> zone; zone -> parentZone

c9d7fc3

Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>

abaguas force-pushed the dnszones/breakingchange branch from c8dc2a7 to c9d7fc3 Compare April 7, 2025 20:36

abaguas marked this pull request as ready for review April 7, 2025 22:28

abaguas requested review from donovanmuller, k0da, kuritka, ytsarev and jkremser as code owners April 7, 2025 22:28

ytsarev previously approved these changes Apr 19, 2025

View reviewed changes

ytsarev reviewed Apr 20, 2025

View reviewed changes

kuritka previously approved these changes Apr 22, 2025

View reviewed changes

abaguas added a commit to abaguas/k8gb that referenced this pull request May 5, 2025

rename domain -> zone; zone -> parentZone

f18090a

Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>

abaguas dismissed stale reviews from kuritka and ytsarev via f18090a May 5, 2025 20:06

abaguas force-pushed the dnszones/breakingchange branch from c9d7fc3 to f18090a Compare May 5, 2025 20:06

abaguas added 2 commits May 14, 2025 19:53

rename domain -> zone; zone -> parentZone

87c4ff1

Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>

abaguas force-pushed the dnszones/breakingchange branch from 36382b7 to 9811509 Compare May 14, 2025 17:56

replace edgeDNSServers with ParentZoneDNSServers

0832d27

Signed-off-by: Andre Aguas <[email protected]>

abaguas force-pushed the dnszones/breakingchange branch from 9811509 to 0832d27 Compare May 14, 2025 17:58

rename zone to loadBalancedZone

3eb8828

Signed-off-by: Andre Aguas <[email protected]>

abaguas force-pushed the dnszones/breakingchange branch from e573eb9 to 3eb8828 Compare May 14, 2025 18:23

abaguas force-pushed the dnszones/breakingchange branch from 0be7264 to d05c782 Compare May 14, 2025 20:36

fix dns zone validation

9903628

Signed-off-by: Andre Aguas <[email protected]>

abaguas force-pushed the dnszones/breakingchange branch from d05c782 to 9903628 Compare May 14, 2025 20:54

kuritka approved these changes May 15, 2025

View reviewed changes

abaguas merged commit 3d5d456 into k8gb-io:master May 15, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[breaking] deprecate dnsZone and edgeDnsZone chart values #1876

[breaking] deprecate dnsZone and edgeDnsZone chart values #1876

Uh oh!

abaguas commented Apr 2, 2025 •

edited

Loading

Uh oh!

netlify bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

abaguas commented Apr 2, 2025

Uh oh!

kuritka commented Apr 2, 2025 •

edited

Loading

Uh oh!

abaguas commented Apr 3, 2025 •

edited

Loading

Uh oh!

kuritka commented Apr 7, 2025 •

edited

Loading

Uh oh!

ytsarev left a comment •

edited

Loading

Uh oh!

ytsarev Apr 20, 2025

Uh oh!

abaguas May 10, 2025

Uh oh!

abaguas May 14, 2025 •

edited

Loading

Uh oh!

ytsarev Apr 20, 2025

Uh oh!

abaguas May 5, 2025

Uh oh!

kuritka left a comment

Uh oh!

Uh oh!

Uh oh!

[breaking] deprecate dnsZone and edgeDnsZone chart values #1876

[breaking] deprecate dnsZone and edgeDnsZone chart values #1876

Uh oh!

Conversation

abaguas commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for k8gb-preview ready!

Uh oh!

abaguas commented Apr 2, 2025

Uh oh!

kuritka commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abaguas commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kuritka commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ytsarev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ytsarev Apr 20, 2025

Choose a reason for hiding this comment

Uh oh!

abaguas May 10, 2025

Choose a reason for hiding this comment

Uh oh!

abaguas May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ytsarev Apr 20, 2025

Choose a reason for hiding this comment

Uh oh!

abaguas May 5, 2025

Choose a reason for hiding this comment

Uh oh!

kuritka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abaguas commented Apr 2, 2025 •

edited

Loading

netlify bot commented Apr 2, 2025 •

edited

Loading

kuritka commented Apr 2, 2025 •

edited

Loading

abaguas commented Apr 3, 2025 •

edited

Loading

kuritka commented Apr 7, 2025 •

edited

Loading

ytsarev left a comment •

edited

Loading

abaguas May 14, 2025 •

edited

Loading