Add support for multiple zones #1845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
ytsarev,
jkremser and
abaguas
as code owners
This PR adds the ability for K8gb to handle multiple edge and DNS zones.
We have a use case where we need to support multiple zones. There were some ideas on how to achieve this. Namely running multiple K8gb deployments in different namespaces, each with its own `edgeDNSZone`/`dnsZone`, but that ultimately turned out to be quite difficult to do given the Helm Chart, CRD and other issues. So we decided to add support for handling multiple `edgeZone`/`zone` pairs, taking inspiration from the `edgeDNSServers` implementation was done.
The Helm Chart has been updated to support the following values as an example of supporting two zones:
```yaml
...
k8gb:
...
dnsZones:
- edgeZone: "example.com"
zone: "cloud.example.com"
dnsZoneNegTTL: 300
- edgeZone: "example.org"
zone: "cloud.example.org"
dnsZoneNegTTL: 300
...
```
The old fields dnsZone and edgeDNSZone are still supported but are now deprecated, so you don't have to change values.yaml unless you want to.
Signed-off-by: Michal Kuritka <[email protected]>
kuritka
force-pushed
the
multi2-last-running
branch
from
fed13ef to
e156e3c
Compare
k0da
approved these changes
Mar 3, 2025
donovanmuller
approved these changes
Mar 3, 2025
abaguas
added a commit
to abaguas/k8gb
that referenced
this pull request
Apr 2, 2025
PR k8gb-io#1845 introduced the possibility to configure multiple DNS zones. The intention was to be backwards compatible. However it forces uses to change the following helm values, as explained in k8gb-io#1858: * k8gb.dnsZoneNegTTL -> k8gb.dnsZones[0].dnsZoneNegTTL * k8gb.edgeDnsZone -> k8gb.dnsZones[0].zone * k8gb.dnsZone -> k8gb.dnsZones[0].domain During the community meeting of 02.04.2025 it was agreed to maintain the breaking change and clean up the deprecated values configuration. Fixes k8gb-io#1858 Signed-off-by: Andre Aguas <[email protected]>
abaguas
added a commit
to abaguas/k8gb
that referenced
this pull request
May 5, 2025
PR k8gb-io#1845 introduced the possibility to configure multiple DNS zones. The intention was to be backwards compatible. However it forces uses to change the following helm values, as explained in k8gb-io#1858: * k8gb.dnsZoneNegTTL -> k8gb.dnsZones[0].dnsZoneNegTTL * k8gb.edgeDnsZone -> k8gb.dnsZones[0].zone * k8gb.dnsZone -> k8gb.dnsZones[0].domain During the community meeting of 02.04.2025 it was agreed to maintain the breaking change and clean up the deprecated values configuration. Fixes k8gb-io#1858 Signed-off-by: Andre Aguas <[email protected]>
abaguas
added a commit
to abaguas/k8gb
that referenced
this pull request
May 14, 2025
PR k8gb-io#1845 introduced the possibility to configure multiple DNS zones. The intention was to be backwards compatible. However it forces uses to change the following helm values, as explained in k8gb-io#1858: * k8gb.dnsZoneNegTTL -> k8gb.dnsZones[0].dnsZoneNegTTL * k8gb.edgeDnsZone -> k8gb.dnsZones[0].zone * k8gb.dnsZone -> k8gb.dnsZones[0].domain During the community meeting of 02.04.2025 it was agreed to maintain the breaking change and clean up the deprecated values configuration. Fixes k8gb-io#1858 Signed-off-by: Andre Aguas <[email protected]>
abaguas
added a commit
that referenced
this pull request
May 15, 2025
PR #1845 introduced the possibility to configure multiple DNS zones. The intention was to be backwards compatible. However it forces uses to change the new helm values, as explained in #1858. The naming of zones was also reviewed, since edgeZone was not very clear. So the change is as follows: * k8gb.dnsZoneNegTTL -> k8gb.dnsZones[0].dnsZoneNegTTL * k8gb.edgeDnsZone -> k8gb.dnsZones[0].parentZone * k8gb.dnsZone -> k8gb.dnsZones[0].loadBalancedZone During the community meeting of 02.04.2025 it was agreed to maintain the breaking change and clean up the deprecated values configuration. Fixes #1858 Signed-off-by: Andre Aguas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #1774)
This PR adds the ability for K8gb to handle multiple edge and DNS zones.
We have a use case where we need to support multiple zones. There were some ideas on how to achieve this. Namely running multiple K8gb deployments in different namespaces, each with its own
edgeDNSZone/dnsZone, but that ultimately turned out to be quite difficult to do given the Helm Chart, CRD and other issues. So we decided to add support for handling multipleedgeZone/zonepairs, taking inspiration from theedgeDNSServersimplementation was done.The Helm Chart has been updated to support the following values as an example of supporting two zones:
The old fields
dnsZoneandedgeDNSZoneare still supported but are now deprecated, so you don't have to changevalues.yamlunless you want to.