[breaking] deprecate dnsZone and edgeDnsZone chart values #1876
Conversation
PR k8gb-io#1845 introduced the possibility to configure multiple DNS zones. The intention was to be backwards compatible. However it forces uses to change the following helm values, as explained in k8gb-io#1858: * k8gb.dnsZoneNegTTL -> k8gb.dnsZones[0].dnsZoneNegTTL * k8gb.edgeDnsZone -> k8gb.dnsZones[0].zone * k8gb.dnsZone -> k8gb.dnsZones[0].domain During the community meeting of 02.04.2025 it was agreed to maintain the breaking change and clean up the deprecated values configuration. Fixes k8gb-io#1858 Signed-off-by: Andre Aguas <[email protected]>
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@kuritka can we rediscuss the new naming of the options?
What is for you the different between zone and domain? Can you explain your reasoning for the change? What was confusing with the previous naming? |
|
Hey, totally valid question – both naming schemes actually make sense. I renamed
You're right that technically both are Happy to revisit if we find better names that keep both clarity and accuracy – e.g. rootZone / subZone could be a compromise. Why do you feel such a need to change it? |
|
I agree edge zone is not very clear.
I feel calling domain to one of the zones will also lead to confusion. So, since we changed it we can get it 100% accurate before the upcoming release. Root zone is the zone controlled by the root servers. But I like the idea of hierarchy it brings. What do you think about "zone"/"k8gbZone"/"delegatedZone" and "parentZone"? |
apart |
Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>
Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>
abaguas
force-pushed
the
dnszones/breakingchange
branch
from
90d58d5 to
c8dc2a7
Compare
Based on the discussion started in: k8gb-io#1876 (comment) Signed-off-by: Andre Aguas <[email protected]>
abaguas
force-pushed
the
dnszones/breakingchange
branch
from
c8dc2a7 to
c9d7fc3
Compare
abaguas
requested review from
donovanmuller,
k0da,
kuritka,
ytsarev and
jkremser
as code owners
| - zone: "example.com" # -- main zone which would contain gslb zone to delegate (same meaning as to edgeDNSZone) | ||
| domain: "cloud.example.com" # -- domain controlled by gslb (same meaning as to dnsZone) | ||
| - parentZone: "example.com" # -- parent zone which would contain gslb zone to delegate (same meaning as to edgeDNSZone) | ||
| zone: "cloud.example.com" # -- zone controlled by gslb (same meaning as to dnsZone) |
There was a problem hiding this comment.
Maybe loadBalancedZone to be explicit?
| "required": [ | ||
| "clusterGeoTag", | ||
| "extGslbClustersGeoTags", | ||
| "edgeDNSServers", |
There was a problem hiding this comment.
We need to change this terminology too to be consistent
PR #1845 introduced the possibility to configure multiple DNS zones. The intention was to be backwards compatible. However it forces uses to change the following helm values, as explained in #1858:
The naming of zones was also reviewed, since edgeZone was not very clear.
During the community meeting of 02.04.2025 it was agreed to maintain the breaking change and clean up the deprecated values configuration.
Upgrade testing obviously fails since this is a breaking change. The old configuration is no longer valid
Fixes #1858