Skip to content

[BUG] iOS build failure with JWPlayerKit 4.20.0 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ PODS:
- Protobuf (~> 3.13)
- GoogleAds-IMA-iOS-SDK (3.22.0)
- hermes-engine (0.70.14)
- JWPlayerKit (4.19.1)
- JWPlayerKit (4.19.2)
- libevent (2.1.12)
- OpenSSL-Universal (1.1.1100)
- Protobuf (3.26.1)
- Protobuf (3.28.3)
- RCT-Folly (2021.07.22.00):
- boost
- DoubleConversion
Expand Down Expand Up @@ -386,9 +386,9 @@ PODS:
- RNGestureHandler (2.12.1):
- React-Core
- RNJWPlayer (1.0.2):
- google-cast-sdk (~> 4.8)
- GoogleAds-IMA-iOS-SDK (~> 3.22)
- JWPlayerKit (>= 4.19.0)
- google-cast-sdk (= 4.8.1)
- GoogleAds-IMA-iOS-SDK (= 3.22.0)
- JWPlayerKit (= 4.19.2)
- React-Core
- RNScreens (3.25.0):
- React-Core
Expand Down Expand Up @@ -600,10 +600,10 @@ SPEC CHECKSUMS:
google-cast-sdk: beb7a3ec3def0e3beb618a849b0f1ab2b15b5ebb
GoogleAds-IMA-iOS-SDK: e594350077f2838a335b40de079a12f0a16e1f6d
hermes-engine: af3982923f6d1af884ece80592bd40be2c62e064
JWPlayerKit: 77075dce53ed80374cd54dfbc50d16e7f8820480
JWPlayerKit: ddc83cdd4864895dbc48b6edf84769aac4c410f0
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
OpenSSL-Universal: ebc357f1e6bc71fa463ccb2fe676756aff50e88c
Protobuf: a53f5173a603075b3522a5c50be63a67a5f3353a
Protobuf: 5a8a7781d8e1004302f108977ac2d5b99323146f
RCT-Folly: 0080d0a6ebf2577475bda044aa59e2ca1f909cda
RCTRequired: 6f42727926c2ef4836fc23169586f3d8d7f5a6e4
RCTTypeSafety: de9b538a8f20ae8c780bf38935f37f303b083fc8
Expand Down Expand Up @@ -637,7 +637,7 @@ SPEC CHECKSUMS:
RNDeviceInfo: 1e3f62b9ec32f7754fac60bd06b8f8a27124e7f0
RNFS: 2bd9eb49dc82fa9676382f0585b992c424cd59df
RNGestureHandler: c0d04458598fcb26052494ae23dda8f8f5162b13
RNJWPlayer: 849f363731d3c76c2df7c67b4f476e8bce3e6ed7
RNJWPlayer: fabfc95a234e9fbcf4fbdf168afa50bc8a9bce10
RNScreens: 85d3880b52d34db7b8eeebe2f1a0e807c05e69fa
RNVectorIcons: 8b5bb0fa61d54cd2020af4f24a51841ce365c7e9
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Expand Down
6 changes: 3 additions & 3 deletions RNJWPlayer.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Pod::Spec.new do |s|
s.platform = :ios, "14.0"
s.source = { :git => "https://github.com/jwplayer/jwplayer-react-native.git", :tag => "v#{s.version}" }
s.source_files = "ios/RNJWPlayer/*.{h,m,swift}"
s.dependency 'JWPlayerKit', '>= 4.19.0'
s.dependency 'JWPlayerKit', '4.19.2'
s.dependency 'React-Core'
s.static_framework = true
s.info_plist = {
Expand All @@ -28,14 +28,14 @@ Pod::Spec.new do |s|

if defined?($RNJWPlayerUseGoogleCast)
Pod::UI.puts "RNJWPlayer: enable Google Cast"
s.dependency 'google-cast-sdk', '~> 4.8'
s.dependency 'google-cast-sdk', '4.8.1'
s.pod_target_xcconfig = {
'OTHER_SWIFT_FLAGS' => '$(inherited) -D USE_GOOGLE_CAST'
}
end
if defined?($RNJWPlayerUseGoogleIMA)
Pod::UI.puts "RNJWPlayer: enable IMA SDK"
s.dependency 'GoogleAds-IMA-iOS-SDK', '~> 3.22'
s.dependency 'GoogleAds-IMA-iOS-SDK', '3.22.0'
s.pod_target_xcconfig = {
'OTHER_SWIFT_FLAGS' => '$(inherited) -D USE_GOOGLE_IMA'
}
Expand Down
4 changes: 0 additions & 4 deletions ios/RNJWPlayer/RNJWPlayerView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1179,10 +1179,6 @@ class RNJWPlayerView : UIView, JWPlayerDelegate, JWPlayerStateDelegate, JWAdDele

// MARK: - JWPlayer State Delegate

func jwplayerContentIsBuffering(_ player:JWPlayer) {
self.onBuffer?([:])
}

func jwplayer(_ player:JWPlayer, isBufferingWithReason reason:JWBufferReason) {
self.onBuffer?([:])
}
Expand Down
5 changes: 0 additions & 5 deletions ios/RNJWPlayer/RNJWPlayerViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,6 @@ class RNJWPlayerViewController : JWPlayerViewController, JWPlayerViewControllerD

// MARK: - JWPlayer State Delegate

override func jwplayerContentIsBuffering(_ player:JWPlayer) {
super.jwplayerContentIsBuffering(player)
parentView?.onBuffer?([:])
}

override func jwplayer(_ player:JWPlayer, isBufferingWithReason reason:JWBufferReason) {
super.jwplayer(player, isBufferingWithReason:reason)
parentView?.onBuffer?([:])
Expand Down