Skip to content

[BUG] iOS build failure with JWPlayerKit 4.20.0 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Remove soon to be deprecated callback
  • Only use a specific version of the iOS SDK.

Why is this Pull Request needed?

  • Prepare for next iOS release with breaking deprecations
  • Ensure the version in the podspec is tested and viable with this wrapper

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner October 14, 2024 17:44
@Jmilham21
Copy link
Collaborator Author

For anyone waiting for this, you will need to ensure your podfile.lock is updated to only use the specific version as stated in the podspec here.

@chriszs
Copy link
Contributor

chriszs commented Nov 15, 2024

Thanks!

@Jmilham21 Jmilham21 requested a review from AmitaiB November 26, 2024 23:04
@Jmilham21 Jmilham21 merged commit 5f03880 into master Nov 27, 2024
@Jmilham21 Jmilham21 deleted the bug/ios-build-failure-with-jwplayerkit-4.20.0 branch November 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants