Skip to content

Update parent #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Update parent #240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fbaa63
Update parent
jglick Mar 22, 2023
2a3d228
Better to just update BOM https://github.com/jenkinsci/workflow-multi…
jglick Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ updates:
directory: "/"
schedule:
interval: "weekly"
ignore:
# Must match transitive version from org.jenkins-ci.plugins:subversion:
- dependency-name: org.tmatesoft.svnkit:svnkit-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why don't we just depend on the version transitively? are their conflicts - or is there a depenencyManagement that is lost due to MNG-5761?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why don't we just depend on the version transitively?

subversion depends only on svnkit (an old version) and does not pass along the svnkit-cli dep.

are [there] conflicts

Yes, which is why #239 failed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also pick up jenkinsci/subversion-plugin#276 via jenkinsci/bom#1672 but that would still be a bit too old. Would need to go up to jenkinsci/subversion-plugin#278 via jenkinsci/bom#1789. 👀

- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ THE SOFTWARE.
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.54</version>
<version>4.56</version>
<relativePath/>
</parent>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
Expand Down Expand Up @@ -183,7 +183,7 @@ THE SOFTWARE.
<dependency>
<groupId>org.tmatesoft.svnkit</groupId>
<artifactId>svnkit-cli</artifactId>
<version>1.10.10</version>
<version>1.10.1</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down