Skip to content

Update parent #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2023
Merged

Update parent #240

merged 2 commits into from
Mar 22, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 22, 2023

@jglick jglick requested a review from a team as a code owner March 22, 2023 17:26
@jglick jglick added the chore label Mar 22, 2023
jtnord
jtnord approved these changes Mar 22, 2023
View reviewed changes
.github/dependabot.yml Outdated
@@ -6,6 +6,9 @@ updates:
directory: "/"
schedule:
interval: "weekly"
ignore:
# Must match transitive version from org.jenkins-ci.plugins:subversion:
- dependency-name: org.tmatesoft.svnkit:svnkit-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why don't we just depend on the version transitively? are their conflicts - or is there a depenencyManagement that is lost due to MNG-5761?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why don't we just depend on the version transitively?

subversion depends only on svnkit (an old version) and does not pass along the svnkit-cli dep.

are [there] conflicts

Yes, which is why #239 failed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also pick up jenkinsci/subversion-plugin#276 via jenkinsci/bom#1672 but that would still be a bit too old. Would need to go up to jenkinsci/subversion-plugin#278 via jenkinsci/bom#1789. 👀

@jglick jglick requested a review from jtnord March 22, 2023 17:49
jglick added a commit to jglick/workflow-cps-plugin that referenced this pull request Mar 22, 2023
@jglick
https://github.com/jenkinsci/workflow-multibranch-plugin/pull/240#dis…
246ee2b 
…cussion_r1145200638
@jglick jglick added dependencies Pull requests that update a dependency file and removed chore labels Mar 22, 2023
jtnord
jtnord approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@jtnord jtnord left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way works, I was just wondering if there was a way we can minimize the human interaction needed going forward.

@jglick
Copy link
Member Author

jglick commented Mar 22, 2023

Unfortunately it does not appear that way. See note in https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.55.

@jglick jglick enabled auto-merge March 22, 2023 17:56
@jglick jglick mentioned this pull request Mar 22, 2023
Merged
@jglick jglick merged commit 542d7fd into jenkinsci:master Mar 22, 2023
@jglick
Copy link
Member Author

jglick commented Mar 22, 2023

(see #238)

@jglick jglick deleted the parent branch March 22, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtnord jtnord jtnord approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @jtnord