Skip to content

allow writeYaml and writeJSON to return text without requiring a node #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2021
Merged

allow writeYaml and writeJSON to return text without requiring a node #94

merged 1 commit into from
Mar 31, 2021

Conversation

rittneje
Copy link
Contributor

Allow writeYaml and writeJSON to run with returnText: true without requiring a node. This is the same way that readYaml and readJSON work when using the text parameter.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@rittneje rittneje marked this pull request as ready for review March 26, 2021 11:56
@rittneje
Copy link
Contributor Author

rittneje commented Mar 26, 2021

@rsandell This is effectively a bugfix for my other two PRs (#88 and #90). I didn't realize this also needed to be changed.

@rsandell rsandell added the bug label Mar 31, 2021
@rsandell rsandell merged commit 15099d3 into jenkinsci:master Mar 31, 2021
@rittneje rittneje deleted the allow-writeyaml-writejson-without-node branch March 31, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants