[JENKINS-63720] add returnText option to writeJSON #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rittneje
commented
Feb 21, 2021
| r.createSlave("dummy4", "a b c d", new EnvVars()), | ||
| }; | ||
| for (DumbSlave dummy : dummies) { | ||
| dummy.toComputer().waitUntilOnline(); |
There was a problem hiding this comment.
These tests were pretty flaky on the Windows agents. I believe it was due to a race condition since it was only waiting for the last dummy to come online.
rsandell
approved these changes
Mar 25, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
returnTextboolean parameter towriteJSONso it returns the json as a string rather than writing it to a file.