Removing IOException when using ZIP with "overwrite: true", and the ZIP doesn't currently exist #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched overwrite logic in ZipStepExecution to no longer throw a IOException if the destination file doesn't exist yet. Motivation being this fixes pipelines failing on a fresh workspace where this file may not exist yet. Not handling IOExceptions from the deletion itself, to try and follow existing functionality (as previous implementation didn't either) so these will still bubble up.
timothy-long
changed the title
rsandell
requested changes
Aug 21, 2020
src/main/java/org/jenkinsci/plugins/pipeline/utility/steps/zip/ZipStepExecution.java
Outdated
Show resolved
Hide resolved
Based on feedback from jenkinsci#82 (comment) Co-authored-by: Robert Sandell <[email protected]>
rsandell
approved these changes
Oct 9, 2020
|
Sorry if I'm asking this in the wrong place. After running into this issue, I updated my Jenkins environment including all plugins to their latest versions only to discover that this PR has not yet been included in a release. The latest release is 2.6.1 from 26th June 2020, when can a new release be expected? |
|
How soon can this be released? this is a pretty glaring issue that makes the new 'overwrite' feature useless |
|
@espguitarist33 Sorry, I had missed making the release. It was released in 2.7.0 last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Currently, when running a pipeline creating a ZIP and specifying "overwrite: true", if the destination file doesn't exist, it will throw an IOException. I've run into this issue often when running a pipeline for the first time, or after clearing a workspace.
The original pull request (#76) checked if the ZIP existed prior to attempting to delete, however this was lost after feedback encouraging converting to NIO2 file APIs, where it now throws an IOException. This pull request changes the functionality to be more like the original.
Return value of Files.deleteIfExists is ignored, as it indicates if the file existed or not, and for overwriting I don't believe we mind either way.
Thanks