[JENKINS-42591] && [JENKINS-47060] Add overwrite option to zip step. #76
Conversation
src/main/resources/org/jenkinsci/plugins/pipeline/utility/steps/zip/ZipStep/help-overwrite.html
Outdated
Show resolved
Hide resolved
| String canonicalZip = new File(zipFile.getRemote()).getCanonicalPath(); | ||
| File zip = new File(zipFile.getRemote()); | ||
| if (overwrite && zip.exists()) { | ||
| if (!zip.delete()) { |
There was a problem hiding this comment.
https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#delete-java.nio.file.Path- would be a better File management API
There was a problem hiding this comment.
I changed it to the api you suggested.
@oleg-nenashev can you check if it is as expected?
Thank you very much
|
|
||
| f.entry(field: 'overwrite', title: _('Overwrite')) { | ||
| f.checkbox() | ||
| } |
There was a problem hiding this comment.
Just a reminder to myself that all the optional arguments should be put behind an advanced section.
| } | ||
|
|
||
| @Override | ||
| public Integer invoke(File dir, VirtualChannel channel) throws IOException, InterruptedException { | ||
| String canonicalZip = new File(zipFile.getRemote()).getCanonicalPath(); | ||
| String canonicalZip = zipFile.getRemote(); | ||
| if (overwrite && !Files.deleteIfExists(Paths.get(canonicalZip))) { |
There was a problem hiding this comment.
So now it throws the exception (and fails) if the zip does not exist and overwrite=true. Was that intended?
My case: I need the file to be overwritten when it exists + be created when it does not. That used to work without specifying the overwrite flag (which wasn't there obviously)
There was a problem hiding this comment.
No, that sounds a bit weird indeed. 🤔
There was a problem hiding this comment.
I am thinking the only workaround for now is to check if file exists before attempting to zip.
Added the possibility to overwrite the zip file in cases where the destination file already exists.