Private memberships can be used for authorization #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -302,7 +302,14 @@ public GithubOAuthUserDetails getUserDetails(String username) { | |||
| if (user != null) { | |||
| List<GrantedAuthority> groups = new ArrayList<GrantedAuthority>(); | |||
| try { | |||
| for (GHOrganization ghOrganization : user.getOrganizations()) { | |||
| GHPersonSet<GHOrganization> orgs; | |||
| if(this.userName.equals(username)) { | |||
There was a problem hiding this comment.
If GitHub scopes don't include the ability to read teams, then all authorizations for a user are wiped. Need to fall back to the default method of determining authorizations publicly.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
@cloudbeesci code review, please. |
|
I don't think anyone is monitoring that account. |
|
@daniel-beck ah, I thought you were responding because I at mentioned that account. I guess not :). Well then I'll just chill out and wait for code reviews to come in. |
samrocketman
force-pushed
the
get_private_orgs
branch
2 times, most recently
from
71df210 to
af11e42
Compare
Private organization memberships can now be used for authorization. fixes [JENKINS-20845]
samrocketman
force-pushed
the
get_private_orgs
branch
from
af11e42 to
8a741c4
Compare
|
This is now ready for code review. |
jamiecobbett
added a commit
to alphagov/ci-puppet
that referenced
this pull request
Sep 29, 2015
Our CI Jenkins uses GitHub enterprise to authenticate users. This doesn't work if your membership of the GDS organisation isn't public. Version 0.22 adds support for these users. See: https://issues.jenkins-ci.org/browse/JENKINS-20845 jenkinsci/github-oauth-plugin#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private organization memberships can now be used for authorization.
fixes JENKINS-20845