Allow Jenkins email to be set using private email #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code review, please. cc @cloudbeesci, @jhoblitt. |
| @@ -21,7 +21,7 @@ | |||
| </f:entry> | |||
|
|
|||
| <f:entry title="OAuth Scope(s)" field="oauthScopes" help="/plugin/github-oauth/help/realm/oauth-scopes-help.html"> | |||
| <f:textbox default="read:org" /> | |||
| <f:textbox default="read:org,user:email" /> | |||
There was a problem hiding this comment.
I'm fairly clueless about jelly<->stapler. Is there a way of calling #defaultOauthScope from the jelly template? That would be a lot better than my kludge of hard coding the default value in two places
There was a problem hiding this comment.
Perhaps, let me see if I can hack something together real quick.
samrocketman
force-pushed
the
use_primary_email
branch
from
cbeedeb to
8b30d25
Compare
|
@jhoblitt updated jelly to include descriptor. Here's how I went about figuring it out.
|
samrocketman
force-pushed
the
use_primary_email
branch
from
8b30d25 to
55ce7c2
Compare
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
samrocketman
force-pushed
the
use_primary_email
branch
from
55ce7c2 to
fc3ea49
Compare
This was referenced Jul 21, 2015
|
I uploaded a new change. It uses a |
samrocketman
force-pushed
the
use_primary_email
branch
3 times, most recently
from
7d93d84 to
642f8c1
Compare
Update default OAuth scope to read:org,user:email. This allows the Jenkins profile email to be set to the private primary GitHub email. user:email scope is optional. If an admin wishes to further restrict it they can. It will fall back to attempting to read a public email. fixes [JENKINS-27764]
samrocketman
force-pushed
the
use_primary_email
branch
from
642f8c1 to
4aff786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default OAuth scope to
read:org,user:email. This allows the Jenkins profile email to be set to the private primary GitHub email.user:emailscope is optional. If an admin wishes to further restrict it they can. It will fall back to attempting to read a public email.fixes JENKINS-27764