Skip to content

fix(acr): new credential settings in proxy backend #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Aug 9, 2024

Fixes: https://issues.redhat.com/browse/RHIDP-3592

This PR updated the credentials to be passed for the proxy and added more context around the new optional credential settings in the backstage 1.28 to explain different settings available to the users.

See Backstage 1.28 release notes about the BREAKING: Proxy backend plugin protected by default -
https://github.com/backstage/backstage/releases/tag/v1.28.0

@invincibleJai invincibleJai requested review from a team as code owners August 9, 2024 08:00
Copy link
Contributor

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

sonarqubecloud bot commented Aug 9, 2024

@openshift-merge-bot openshift-merge-bot bot merged commit 4e57025 into janus-idp:main Aug 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants