Skip to content

docs(Quay): update quay plugin README.md #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

yangcao77
Copy link
Contributor

the proxy config is wrong, added endpoints to fix it.

the wrong doc brought a lot confusion. the issue has been identified in https://redhat-internal.slack.com/archives/C05HGAR2DT5/p1714587620348839

the proxy config is wrong, added endpoints to fix it.
@yangcao77 yangcao77 requested review from fmenesesg and a team as code owners May 2, 2024 16:55
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yangcao77 yangcao77 changed the title Update README.md docs-Update README.md May 2, 2024
@yangcao77 yangcao77 changed the title docs-Update README.md docs: Update quay plugin README.md May 2, 2024
@invincibleJai
Copy link
Member

@yangcao77 Thanks for the PR, can you update the commit and title to docs(Quay): Update quay plugin README.md to make semantic job happier

/cc @karthikjeeyar

@openshift-ci openshift-ci bot requested a review from karthikjeeyar May 6, 2024 09:57
@yangcao77 yangcao77 changed the title docs: Update quay plugin README.md docs(Quay): Update quay plugin README.md May 6, 2024
@karthikjeeyar
Copy link
Contributor

/lgtm
/approve

Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karthikjeeyar
Once this PR has been reviewed and has the lgtm label, please assign nickboldt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 requested a review from a team as a code owner June 7, 2024 15:25
@openshift-ci openshift-ci bot removed the lgtm label Jun 7, 2024
Copy link

openshift-ci bot commented Jun 7, 2024

New changes are detected. LGTM label has been removed.

Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yangcao77 yangcao77 changed the title docs(Quay): Update quay plugin README.md docs(Quay): update quay plugin README.md Jun 7, 2024
@karthikjeeyar
Copy link
Contributor

/retest

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karthikjeeyar
Copy link
Contributor

Closing this PR in favor of #2032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants