feat(bulk-import): add fields for annotations, labels and spec input #1950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ciiay
force-pushed
the
rhidp-2927-add-fields-for-annotations-labels-spec
branch
from
5a01b0a to
2bb1fd1
Compare
ciiay
changed the title
ciiay
force-pushed
the
rhidp-2927-add-fields-for-annotations-labels-spec
branch
from
2bb1fd1 to
0a86cc4
Compare
|
Looks good to me, thank you! |
ciiay
force-pushed
the
rhidp-2927-add-fields-for-annotations-labels-spec
branch
from
d2cb2ea to
4bc6f8d
Compare
ciiay
force-pushed
the
rhidp-2927-add-fields-for-annotations-labels-spec
branch
4 times, most recently
from
82ed156 to
cdc8f77
Compare
debsmita1
requested changes
Aug 5, 2024
ciiay
force-pushed
the
rhidp-2927-add-fields-for-annotations-labels-spec
branch
2 times, most recently
from
0d3bedf to
4da2d33
Compare
|
Tested it locally and it works fine |
Signed-off-by: Yi Cai <[email protected]>
ciiay
force-pushed
the
rhidp-2927-add-fields-for-annotations-labels-spec
branch
from
6a0a108 to
a5c1143
Compare
|
|
/lgtm |
debsmita1
approved these changes
Aug 6, 2024
janus-idp bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## @janus-idp/backstage-plugin-bulk-import [1.2.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([#1950](#1950)) ([a1b790a](a1b790a))
janus-idp bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## [1.17.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([#1950](#1950)) ([a1b790a](a1b790a)) * **rbac:** nested condition ([#1814](#1814)) ([228f1a9](228f1a9)) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([#2012](#2012)) ([97c9667](97c9667)) * **acr:** revert downgrade of shared-react and janus-cli ([#2009](#2009)) ([8c28891](8c28891)) * **rbac:** implement conditional aliases ([#1847](#1847)) ([dbc9a0b](dbc9a0b))
janus-idp bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## [4.7.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([#1950](#1950)) ([a1b790a](a1b790a)) * **rbac:** nested condition ([#1814](#1814)) ([228f1a9](228f1a9)) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([#2012](#2012)) ([97c9667](97c9667)) * **acr:** revert downgrade of shared-react and janus-cli ([#2009](#2009)) ([8c28891](8c28891)) * **rbac:** implement conditional aliases ([#1847](#1847)) ([dbc9a0b](dbc9a0b))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
…anus-idp#1950) Signed-off-by: Yi Cai <[email protected]>
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## 1.0.0 (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([janus-idp#1950](janus-idp#1950)) ([a1b790a](janus-idp@a1b790a))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## @janus-idp/backstage-plugin-bulk-import [1.2.0](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([janus-idp#1950](janus-idp#1950)) ([a1b790a](janus-idp@a1b790a))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## [1.17.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([janus-idp#1950](janus-idp#1950)) ([a1b790a](janus-idp@a1b790a)) * **rbac:** nested condition ([janus-idp#1814](janus-idp#1814)) ([228f1a9](janus-idp@228f1a9)) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([janus-idp#2012](janus-idp#2012)) ([97c9667](janus-idp@97c9667)) * **acr:** revert downgrade of shared-react and janus-cli ([janus-idp#2009](janus-idp#2009)) ([8c28891](janus-idp@8c28891)) * **rbac:** implement conditional aliases ([janus-idp#1847](janus-idp#1847)) ([dbc9a0b](janus-idp@dbc9a0b))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## [4.7.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([janus-idp#1950](janus-idp#1950)) ([a1b790a](janus-idp@a1b790a)) * **rbac:** nested condition ([janus-idp#1814](janus-idp#1814)) ([228f1a9](janus-idp@228f1a9)) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([janus-idp#2012](janus-idp#2012)) ([97c9667](janus-idp@97c9667)) * **acr:** revert downgrade of shared-react and janus-cli ([janus-idp#2009](janus-idp#2009)) ([8c28891](janus-idp@8c28891)) * **rbac:** implement conditional aliases ([janus-idp#1847](janus-idp#1847)) ([dbc9a0b](janus-idp@dbc9a0b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RHIDP-2927
Screen recording:
rhidp_2927.mov