fix(rbac): implement conditional aliases #1847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AndrienkoAleksandr
force-pushed
the
implement-conditional-aliases
branch
from
82e33e5 to
72100d7
Compare
AndrienkoAleksandr
force-pushed
the
implement-conditional-aliases
branch
from
13c53a4 to
393ec70
Compare
AndrienkoAleksandr
force-pushed
the
implement-conditional-aliases
branch
from
170725b to
60aee15
Compare
PatAKnight
reviewed
Jul 29, 2024
AndrienkoAleksandr
force-pushed
the
implement-conditional-aliases
branch
from
60aee15 to
3dbd7c0
Compare
AndrienkoAleksandr
force-pushed
the
implement-conditional-aliases
branch
3 times, most recently
from
56b1a1e to
b4e75ad
Compare
|
I updated demo to count changes. |
AndrienkoAleksandr
force-pushed
the
implement-conditional-aliases
branch
2 times, most recently
from
bbc63d9 to
91ba830
Compare
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
AndrienkoAleksandr
force-pushed
the
implement-conditional-aliases
branch
from
91ba830 to
c7be861
Compare
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
|
janus-idp bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## @janus-idp/backstage-plugin-rbac-common [1.8.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Bug Fixes * **rbac:** implement conditional aliases ([#1847](#1847)) ([dbc9a0b](dbc9a0b))
janus-idp bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## [1.17.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([#1950](#1950)) ([a1b790a](a1b790a)) * **rbac:** nested condition ([#1814](#1814)) ([228f1a9](228f1a9)) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([#2012](#2012)) ([97c9667](97c9667)) * **acr:** revert downgrade of shared-react and janus-cli ([#2009](#2009)) ([8c28891](8c28891)) * **rbac:** implement conditional aliases ([#1847](#1847)) ([dbc9a0b](dbc9a0b))
janus-idp bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## [1.27.1](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([#2012](#2012)) ([97c9667](97c9667)) * **rbac:** implement conditional aliases ([#1847](#1847)) ([dbc9a0b](dbc9a0b))
janus-idp bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## [4.7.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([#1950](#1950)) ([a1b790a](a1b790a)) * **rbac:** nested condition ([#1814](#1814)) ([228f1a9](228f1a9)) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([#2012](#2012)) ([97c9667](97c9667)) * **acr:** revert downgrade of shared-react and janus-cli ([#2009](#2009)) ([8c28891](8c28891)) * **rbac:** implement conditional aliases ([#1847](#1847)) ([dbc9a0b](dbc9a0b))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
* fix(rbac): implement conditional aliases Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): fix build Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): rework currentUser alias to cover ownershipEntityRefs Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): add more unit tests Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): make feature working after backstage update to 1.29.2 Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): fix compilation and tests Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): Support two aliases: currentUser and ownerRefs Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): add doc about conditional policies aliases Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): clean up unit test Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): clean up Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): clean up Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): fix dependencies Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): update yarn.lock Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]>
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## 1.0.0 (2024-08-06) ### Bug Fixes * **rbac:** implement conditional aliases ([janus-idp#1847](janus-idp#1847)) ([dbc9a0b](janus-idp@dbc9a0b))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## @janus-idp/backstage-plugin-rbac-common [1.8.2](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Bug Fixes * **rbac:** implement conditional aliases ([janus-idp#1847](janus-idp#1847)) ([dbc9a0b](janus-idp@dbc9a0b))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## [1.17.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([janus-idp#1950](janus-idp#1950)) ([a1b790a](janus-idp@a1b790a)) * **rbac:** nested condition ([janus-idp#1814](janus-idp#1814)) ([228f1a9](janus-idp@228f1a9)) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([janus-idp#2012](janus-idp#2012)) ([97c9667](janus-idp@97c9667)) * **acr:** revert downgrade of shared-react and janus-cli ([janus-idp#2009](janus-idp#2009)) ([8c28891](janus-idp@8c28891)) * **rbac:** implement conditional aliases ([janus-idp#1847](janus-idp#1847)) ([dbc9a0b](janus-idp@dbc9a0b))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## [1.27.1](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([janus-idp#2012](janus-idp#2012)) ([97c9667](janus-idp@97c9667)) * **rbac:** implement conditional aliases ([janus-idp#1847](janus-idp#1847)) ([dbc9a0b](janus-idp@dbc9a0b))
debsmita1
pushed a commit
to debsmita1/backstage-plugins
that referenced
this pull request
Aug 9, 2024
## [4.7.3](https://github.com/janus-idp/backstage-plugins/compare/@janus-idp/[email protected]...@janus-idp/[email protected]) (2024-08-06) ### Features * **bulk-import:** add fields for annotations, labels and spec input ([janus-idp#1950](janus-idp#1950)) ([a1b790a](janus-idp@a1b790a)) * **rbac:** nested condition ([janus-idp#1814](janus-idp#1814)) ([228f1a9](janus-idp@228f1a9)) ### Bug Fixes * **aap:** revert downgrade of janus-cli ([janus-idp#2012](janus-idp#2012)) ([97c9667](janus-idp@97c9667)) * **acr:** revert downgrade of shared-react and janus-cli ([janus-idp#2009](janus-idp#2009)) ([8c28891](janus-idp@8c28891)) * **rbac:** implement conditional aliases ([janus-idp#1847](janus-idp#1847)) ([dbc9a0b](janus-idp@dbc9a0b))
This was referenced Oct 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What doest this pull request do:
Implement conditional aliases
What does this pull request fix:
https://issues.redhat.com/browse/RHIDP-1765
Demo
(https://youtu.be/XyAf6K28ISE)