Periodic table UX improvements #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values to be > 1' error message
change default zero_color="#eee" to "#eff"
janosh
added
matplotlib
janosh
added a commit
that referenced
this pull request
Mar 28, 2025
* ptable_heatmap() add keywords label_font_size: int = 16, value_font_size: int = 12 * move keyword zero_color to zero_symbol * rename ptable cmap keyword to colorscale * fix ptable_heatmap_plotly only compute log_cbar if needed * ptable_heatmap_plotly improve 'Log color scale requires all heat map values to be > 1' error message * add special value auto_reverse for ptable_heatmap text_color * count_elements auto-convert exclude_elements to list if str or tuple * ptable_heatmap add keyword tile_size: float | tuple[float, float] = 0.9 * utils.py add functions luminance() and pick_bw_for_contrast() * use pick_bw_for_contrast for auto text_color in ptable_heatmap * ptable change default colorscale="summer_r" to "viridis" change default zero_color="#eee" to "#eff" * test_utils.py add test_luminance and test_pick_bw_for_contrast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. auto-pick text color to maximize contrast with heatmap color of element tiles. Example:
ae77997 fix invalid
count_modeValueErrorerr msgbc64aa7
annotate_barsadd keywordadjust_test_pos: bool = False(#94)15f6596
ptable_heatmapadd keywordslabel_font_size: int = 16,value_font_size: int = 120600a76 move keyword
zero_colortozero_symbol18a6869 rename
ptable_heatmapcmapkeyword tocolorscale7e82aae fix
ptable_heatmap_plotlyonly computelog_cbarif needed9658431
ptable_heatmap_plotlyimprove'Log color scale requires all heat map values to be > 1'error messagebd068e4 add special value
auto_reverseforptable_heatmaptext_color(later reverted)96e3580
count_elementsauto-convertexclude_elementstolistifstrortuplee0ddbe9
ptable_heatmapadd keywordtile_size: float | tuple[float, float] = 0.9c348662
utils.pyadd functionsluminance()andpick_bw_for_contrast()7327af6 use
pick_bw_for_contrastfor autotext_colorinptable_heatmap241aa68
ptablechange defaultcolorscale="summer_r"to"viridis"b47815b
test_utils.pyaddtest_luminanceandtest_pick_bw_for_contrast