Skip to content

annotate_bars add keyword adjust_test_pos: bool = False #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

janosh
Copy link
Owner

@janosh janosh commented Oct 18, 2023

ca80868 pyproject.toml add extra deps auto-text-pos = ["adjustText"]
6ea548b readme add zenodo DOI badge
70b7624 use dict.setdefault where appropriate
a4f4b3c pymatviz/utils.py annotate_bars add keyword adjust_test_pos: bool = False
c5bcb42 test_utils.py add test_annotate_bars

@janosh janosh added enhancement Improvement to existing features/functionality testing Test all the things matplotlib Concerning matplotlib-powered functions ux User experience labels Oct 18, 2023
@janosh janosh enabled auto-merge (squash) October 18, 2023 02:23
@janosh janosh temporarily deployed to github-pages October 18, 2023 02:25 — with GitHub Actions Inactive
hist_elemental_prevalence(glass_formulas, log=True)

tests/test_ptable.py:109:
ValueError: Got 7 labels but 14 bars to annotate
@janosh janosh temporarily deployed to github-pages October 18, 2023 03:22 — with GitHub Actions Inactive
@janosh janosh merged commit bc64aa7 into main Oct 18, 2023
@janosh janosh deleted the annotate-bars-adjust-test-pos branch October 18, 2023 03:29
janosh added a commit that referenced this pull request Mar 28, 2025
* pyproject.toml add extra deps auto-text-pos = ["adjustText"]

* readme add zenodo DOI badge

* use dict.setdefault where appropriate

* pymatviz/utils.py annotate_bars add keyword adjust_test_pos: bool = False

* test_utils.py add test_annotate_bars

annotate_bars was previously untested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing features/functionality matplotlib Concerning matplotlib-powered functions testing Test all the things ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant