Skip to content

Test against Ruby 3.4 and fix CI #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Mar 31, 2025

Requires:


  • Test against Ruby 3.4
  • Make sure to run CI against different Ruby versions instead of 3.3
  • Pluginify RuboCop config

Additionally:

  • Update RuboCop dependencies
  • Use GitHub formatter for RuboCop action
  • Use an example test domain to prevent information disclosure
  • Ensure "reset configuration" is used when configuration is changed

Before

image

@tagliala tagliala force-pushed the chore/update-rubocop branch from 3ae2602 to 52eff7b Compare March 31, 2025 12:07
@tagliala tagliala changed the title Update RuboCop dependencies Test against Ruby 3.4 and fix CI Mar 31, 2025
@tagliala tagliala force-pushed the chore/update-rubocop branch from 52eff7b to 8d452c7 Compare March 31, 2025 12:09
@tagliala tagliala marked this pull request as draft March 31, 2025 12:09
@tagliala tagliala force-pushed the chore/update-rubocop branch from 8d452c7 to 54bb486 Compare March 31, 2025 15:41
- Test against Ruby 3.4
- Make sure to run CI against different Ruby versions instead of 3.3
- Pluginify RuboCop config

Additionally:
- Update RuboCop dependencies
- Use GitHub formatter for RuboCop action
- Use an example test domain to prevent information disclosure
- Ensure "reset configuration" is used when configuration is changed
@tagliala tagliala force-pushed the chore/update-rubocop branch from 54bb486 to 04ac000 Compare April 24, 2025 07:56
@tagliala tagliala marked this pull request as ready for review April 24, 2025 07:56
@tagliala
Copy link
Contributor Author

@jamesmartin updated, rebased, force-pushed, and ready for review

Copy link
Owner

@jamesmartin jamesmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tagliala. 👍 ✨

@jamesmartin jamesmartin merged commit 2263526 into jamesmartin:master May 6, 2025
8 checks passed
@tagliala tagliala deleted the chore/update-rubocop branch May 6, 2025 07:49
@tagliala
Copy link
Contributor Author

tagliala commented May 6, 2025

@jamesmartin thanks

Are you interested in releasing a 2.0.0? I can prepare it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants