Merge pull request #183 from tagliala/chore/update-rubocop

Test against Ruby 3.4 and fix CI

Author: jamesmartin

.github/workflows/rubocop.yml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['3.3']
+        ruby-version: ['3.4']
 
     continue-on-error: ${{ matrix.channel != 'stable' }}
 
@@ -24,8 +24,8 @@ jobs:
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: '3.3'
+        ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: true
     - name: Test with Rake
       run: |
-        bundle exec rubocop
+        bundle exec rubocop --format github

.github/workflows/ruby.yml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['3.1', '3.2', '3.3']
+        ruby-version: ['3.1', '3.2', '3.3', '3.4']
         channel: ['stable']
 
         include:
@@ -29,7 +29,7 @@ jobs:
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: '3.3'
+        ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: true
     - name: Test with Rake
       run: |

.rubocop.yml

@@ -1,6 +1,6 @@
 inherit_from: .rubocop_todo.yml
 
-require:
+plugins:
   - rubocop-packaging
   - rubocop-performance
   - rubocop-rake

Gemfile

@@ -10,10 +10,10 @@ gem "pry"
 gem "rake"
 gem "rspec"
 
-gem "rubocop", "1.69.2", require: false
-gem "rubocop-packaging", "0.5.2", require: false
-gem "rubocop-performance", "1.23.0", require: false
-gem "rubocop-rake", "0.6.0", require: false
-gem "rubocop-rspec", "3.3.0", require: false
+gem "rubocop", "1.75.3", require: false
+gem "rubocop-packaging", "0.6.0", require: false
+gem "rubocop-performance", "1.25.0", require: false
+gem "rubocop-rake", "0.7.1", require: false
+gem "rubocop-rspec", "3.6.0", require: false
 
 gem "simplecov", require: false

spec/finds_asset_paths_spec.rb

@@ -86,13 +86,13 @@
       shakapacker = double('ShakapackerDouble')
 
       expect(shakapacker).to receive(:find_asset).with('some-file')
-                                                 .and_return(double(filename: Pathname('https://my-fancy-domain.test/full/path/to/some-file')))
+                                                 .and_return(double(filename: Pathname('https://test.example.org/full/path/to/some-file')))
 
       InlineSvg.configure do |config|
         config.asset_finder = shakapacker
       end
 
-      expect(InlineSvg::FindsAssetPaths.by_filename('some-file')).to eq Pathname('https://my-fancy-domain.test/full/path/to/some-file')
+      expect(InlineSvg::FindsAssetPaths.by_filename('some-file')).to eq Pathname('https://test.example.org/full/path/to/some-file')
     end
   end
 end

spec/helpers/inline_svg_spec.rb

@@ -15,11 +15,11 @@ def transform(doc)
   let(:helper) { (Class.new { include InlineSvg::ActionView::Helpers }).new }
 
   shared_examples "inline_svg helper" do |helper_method:|
-    context "when passed the name of an SVG that does not exist" do
-      after do
-        InlineSvg.reset_configuration!
-      end
+    after do
+      InlineSvg.reset_configuration!
+    end
 
+    context "when passed the name of an SVG that does not exist" do
       context "and configured to raise" do
         before do
           InlineSvg.configure do |config|
@@ -166,10 +166,6 @@ def transform(doc)
           end
         end
 
-        after do
-          InlineSvg.reset_configuration!
-        end
-
         it "applies custm transformations to the output" do
           input_svg = '<svg></svg>'
           expected_output = '<svg custom="some value"></svg>'
@@ -185,10 +181,6 @@ def transform(doc)
           end
         end
 
-        after do
-          InlineSvg.reset_configuration!
-        end
-
         context "without passing the attribute value" do
           it "applies custom transformations to the output using the default value" do
             input_svg = '<svg></svg>'