Ipns/refactor unixfs #865
Merged
Ipns/refactor unixfs #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
whyrusleeping
force-pushed
the
ipns/refactor-unixfs
branch
from
b9f385f to
03c966b
Compare
whyrusleeping
force-pushed
the
ipns/refactor-unixfs
branch
from
03c966b to
0e9772c
Compare
| // Removes the child node at the given index | ||
| func (n *UnixfsNode) RemoveChild(index int) { | ||
| n.ufmt.RemoveBlockSize(index) | ||
| n.node.Links = append(n.node.Links[:index], n.node.Links[index+1:]...) |
There was a problem hiding this comment.
should check index is in the right range or this will panic-- maybe that's ok
There was a problem hiding this comment.
I think of it as a normal array access, you wouldnt try doing node.Links[i] if you werent already sure i was in the proper range
|
LGTM! RTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the unixfs 'MultiBlock' object into a more general 'FSNode' object and adds some methods to the related code making it easier to work with.
This is PR number 2 of the ipns set