Writeable IPNS #841
Closed
Writeable IPNS #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/ipns-again
branch
3 times, most recently
from
5a89d44 to
b36438c
Compare
whyrusleeping
force-pushed
the
feat/ipns-again
branch
from
666b906 to
3d27b80
Compare
whyrusleeping
force-pushed
the
feat/ipns-again
branch
from
22dc275 to
5b71881
Compare
| } | ||
| if n.IpnsFs != nil { | ||
| addCloser(n.IpnsFs) | ||
| } |
There was a problem hiding this comment.
you can just call
addCloser(n.Blocks)
addCloser(n.IpnsFs)all it does is check for nil
| @@ -86,7 +91,7 @@ func (db *DagBuilderHelper) FillNodeLayer(node *UnixfsNode) error { | |||
|
|
|||
| // while we have room AND we're not done | |||
| for node.NumChildren() < db.maxlinks && !db.Done() { | |||
| child := NewUnixfsNode() | |||
| child := NewUnixfsBlock() | |||
|
I think the TrickleDAG algo is very error prone-- lots of special casing and edge casing-- can the code be simpler? more expressive? more functions may help. |
| @@ -0,0 +1,340 @@ | |||
| package ipnsfs | |||
There was a problem hiding this comment.
so ipnsfs is a pkg sort of like unixfs?
There was a problem hiding this comment.
i cant check for correctness until i understand more all the things this package is supposed to handle. maybe write a package doc?
|
Major note: there are many different PRs in here:
It would be really useful to examine, test, + merge each in isolation, let's split them. |
|
👍 on splitting up into multiple PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dont CR this if you dont have lots of free time. Its just up here for regression tests