Skip to content

Add "test/dependencies" dir and "godep restore" test #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2015

Conversation

chriscool
Copy link
Contributor

This is to avoid problems like those in PR #591 (Fix bad commit sha1 for go-multiaddr-net dependency).

License: MIT
Signed-off-by: Christian Couder [email protected]

@jbenet
Copy link
Member

jbenet commented Jan 19, 2015

@chriscool this will be helpful, but the one issue is that running godep restore may break the user's workspace and other packages, as it forces the installation of our versions. Ideally we could make godep restore things to a different directory, maybe the way to do it would be to set $GOPATH to a tmp directory removed at the end of the test run.

@chriscool
Copy link
Contributor Author

Ok, I will see what I can do.

License: MIT
Signed-off-by: Christian Couder <[email protected]>
@chriscool chriscool force-pushed the add_dependencies_test branch from eb55cf7 to 31d07f0 Compare January 23, 2015 20:33
@chriscool
Copy link
Contributor Author

@jbenet here is a new version using a temporary GOPATH as you suggest.
When running the new test here, it fails with:

# cd /home/christian/gocode/src/github.com/jbenet/goprocess; git checkout c37725a4a97d6ad772818b071ceef82789562142
fatal: reference is not a tree: c37725a4a97d6ad772818b071ceef82789562142
godep: restore: exit status 128

But I think it proves it correctly detect problems, and the problem should be fixed ;-)

@jbenet
Copy link
Member

jbenet commented Jan 24, 2015

@chriscool indeed! this should fix it :)

jbenet added a commit that referenced this pull request Jan 24, 2015
Add "test/dependencies" dir and "godep restore" test
@jbenet jbenet merged commit aac9891 into ipfs:master Jan 24, 2015
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
stricter definition of public for DHT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants