Fix bad commit sha1 for go-multiaddr-net dependency #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently running "godep restore" on master results in: fatal: reference is not a tree: 04044c2289504304472715d827a8f564fa3759a8 godep: restore: exit status 128 This patch fixes this. License: MIT Signed-off-by: Christian Couder <[email protected]>
|
Maybe we should have a test that runs |
|
@chriscool i apologize, this was my mistake, i hadn't pushed a recent commit to go-multiaddr-net: multiformats/go-multiaddr-net@04044c2 -- does this fix the problem?
Yes, we really should. |
|
Okay, i'll close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running "godep restore" on master results in:
fatal: reference is not a tree: 04044c2289504304472715d827a8f564fa3759a8
godep: restore: exit status 128
This patch fixes this.
License: MIT
Signed-off-by: Christian Couder [email protected]