Skip to content

chore: alphabetically sort dev-requirements.txt #4890 #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

AshishYesale7
Copy link
Contributor

@AshishYesale7 AshishYesale7 commented Mar 3, 2025

This PR sorts the dev-requirements.txt file alphabetically to improve readability.

Fixes #4890

@AshishYesale7 AshishYesale7 changed the title fix: week error in fuzzing scripts #4892 chore: alphabetically sort dev-requirements.txt #4890 Mar 4, 2025
@AshishYesale7 AshishYesale7 reopened this Mar 4, 2025
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below. Looks like you had an unresolved diff, probably because of an end of file whitespace difference.

@AshishYesale7 AshishYesale7 requested a review from terriko March 4, 2025 00:45
@AshishYesale7
Copy link
Contributor Author

Apologies for the confusion earlier! I mistakenly caused some merge conflicts while sorting the file alphabetically.

I’ve resolved the conflicts, re-sorted the file correctly, and am pushing the updated changes. 

Thank you for your patience, and I appreciate the feedback! 🤗

@mastersans
Copy link
Member

I have kicked off CI, will be back once they run.

@mastersans
Copy link
Member

@AshishYesale7 It seems you got merge conflict from this PR you need to fix them and update the branch.

@terriko
Copy link
Contributor

terriko commented Mar 4, 2025

Ugh, sorry about the merge conflict; I'd forgotten that our monthly pre-commit update would cause problems for you. Let me know if you need help resolving it!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the sync-upstream.yml file from this PR? It's not related to this PR and it seems like it's a personal branch thing for you.

@AshishYesale7 AshishYesale7 requested a review from terriko March 4, 2025 20:40
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're all ready to merge! Thank you @AshishYesale7 and congratulations on your first merged commit with us!

@terriko terriko merged commit 5e4fd1a into intel:main Mar 5, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: alphabetically sort dev-requirements.txt
3 participants