Skip to content

chore: update pre-commit config #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025
Merged

chore: update pre-commit config #4736

merged 4 commits into from
Mar 4, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 1, 2025

Automated changes by create-pull-request GitHub action

@terriko
Copy link
Contributor

terriko commented Feb 5, 2025

Flagging this as blocked because I really don't want to deal with updating pre-commit until there aren't 50+ pull requests that could be affected.

@terriko terriko added the blocked label Feb 5, 2025
@github-actions github-actions bot force-pushed the chore-precommit-config branch from 9277b6f to 6fac0d6 Compare March 1, 2025 00:09
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing and re-opening for tests. Assuming the linters pass this should be safe to merge.

@terriko terriko enabled auto-merge (squash) March 3, 2025 18:53
Copy link
Contributor Author

github-actions bot commented Mar 3, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

codespell

These words are not needed and should be removed aiohttp cdx cwes getbootstrap GMS NOTKNOWN pyyaml rdf skontar spdx Svunknown urllib

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:intel/cve-bin-tool.git repository
on the chore-precommit-config branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/intel/cve-bin-tool/actions/runs/13638241893/attempts/1'

@terriko
Copy link
Contributor

terriko commented Mar 4, 2025

Hm, looks like there may be some black issues that need resolving. I'm going to bump the branch to fix the spelling issue but I'll probably have to come back and make bigger changes for black.

@terriko terriko added awaiting maintainer Need a maintainer to respond / help out awaiting CI labels Mar 4, 2025
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the relevant linters have passed with the fixes I made, so I'm going to go ahead and mark this as approved for when the other tests finish.

@terriko terriko merged commit 39d5049 into main Mar 4, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting CI awaiting maintainer Need a maintainer to respond / help out blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants