Skip to content

fix: dotnet test bug #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

Saksham-Sirohi
Copy link
Contributor

Summary

This PR fixes the failing test in test/test_scanner.py caused by recent merges of clang and .NET-related changes. The test was asserting that clang should not be present, which led to unintended failures. This update ensures that the test properly accommodates clang detection while still verifying the .NET package.

Changes Introduced

Fixed Test Failures:
Updated test_data/dotnet.py to account for clang detection in the .NET package check.
Adjusted assertions to reflect the expected behaviour after recent merges.

Ensured Stability of Tests:
Verified that the updated test runs successfully with all expected inputs.
Re-ran all relevant test cases to confirm no regressions.

Compatibility:
No breaking changes; ensures the test correctly adapts to recent code updates.

Checklist:

  • Code follows project coding standards.
  • All relevant tests pass successfully.
  • Verified no unintended side effects from the fix.

Steps to Test:
Run the following command to validate the fix:
LONG_TESTS=1 pytest test/test_scanner.py

Related Issues:

Fixes #4841

Additional Notes:
This fix ensures that test logic aligns with recent clang-related changes 🚀.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I imagine a lot of folk will be happy to have the tests behaving again, but especially me since checking each PR to make sure it was only the expected test that failed can be a huge pain!

@terriko
Copy link
Contributor

terriko commented Feb 24, 2025

Merge time now. There's a weird failure happening on windows, but it doesn't look related to this PR. I'll keep an eye on it while i work on other code review today.

@terriko terriko merged commit 1d73da7 into intel:main Feb 24, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: .net test bug
2 participants