Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing test in test/test_scanner.py caused by recent merges of clang and .NET-related changes. The test was asserting that clang should not be present, which led to unintended failures. This update ensures that the test properly accommodates clang detection while still verifying the .NET package.
Changes Introduced
Fixed Test Failures:
Updated test_data/dotnet.py to account for clang detection in the .NET package check.
Adjusted assertions to reflect the expected behaviour after recent merges.
Ensured Stability of Tests:
Verified that the updated test runs successfully with all expected inputs.
Re-ran all relevant test cases to confirm no regressions.
Compatibility:
No breaking changes; ensures the test correctly adapts to recent code updates.
Checklist:
Steps to Test:
Run the following command to validate the fix:
LONG_TESTS=1 pytest test/test_scanner.py
Related Issues:
Fixes #4841
Additional Notes:
This fix ensures that test logic aligns with recent clang-related changes 🚀.