Skip to content

feat(checker): Add jbig #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

feat(checker): Add jbig #4742

merged 1 commit into from
Mar 4, 2025

Conversation

qmfrederik
Copy link
Contributor

No description provided.

@ffontaine
Copy link
Contributor

There is a typo in jbig.py: glib

@qmfrederik
Copy link
Contributor Author

Thanks @ffontaine for spotting that. Fixed and rebased. I was wondering if some templating / tooling for creating a new scanner could help avoid some of these issues :-)

@ffontaine
Copy link
Contributor

There is already the helper-script that can help to create a new checker: https://github.com/intel/cve-bin-tool/blob/main/cve_bin_tool/checkers/README.md#helper-script
However, perhaps an automatic check could also be run on all Pull Request.

@qmfrederik
Copy link
Contributor Author

@terriko This fails on Testing / Tests that may fail due to network or HTML (pull_request), but looks good otherwise?

@ffontaine
Copy link
Contributor

Tests are failing since commit 448c159 which forgot to add clang in other_products of dotnet-runtime-8.0_8.0.12-0ubuntu1~24.10.1_amd64.deb:

FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://security.ubuntu.com/ubuntu/pool/main/d/dotnet8/-dotnet-runtime-8.0_8.0.12-0ubuntu1~24.10.1_amd64.deb-.net-8.0.12-other_products188] - AssertionError: clang found in dotnet-runtime-8.0_8.0.12-0ubuntu1~24.10.1_amd64.deb. If that's expected, make sure to add clang to the expected list of other_products.
assert 'clang' not in {'.net', 'clang', 'system.net.http'}

Merging #4842 will fix this issue

@qmfrederik
Copy link
Contributor Author

Thanks @ffontaine . It was a combination of #4754 and #4750, I cherry-picked 6433da4 which fixes this like you said.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the CI issues. i think we're good to merge this regardless, thank you!

@terriko terriko merged commit 6b95268 into intel:main Mar 4, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants