Fix scroll cursor ("arrow") position on screen edges for software rendered cursor #9852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Districh-ru
changed the title
Districh-ru
commented
May 28, 2025
| return; | ||
|
|
||
| getActiveArea( _prevRoi, width(), height() ); |
There was a problem hiding this comment.
There is no need to call getActiveArea() for _prevRoi here on every call because in line 1407 _prevRoi = temp; and temp is already "updated" by getActiveArea().
The only other place where _prevRoi can get beyond the screen bounds is Display::updateNextRenderRoi(). So I moved getActiveArea( _prevRoi, width(), height() ); there because that method is called much less often than this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #344
This PR fixes "arrow cursor" the going out of screen bounds when software cursor rendering is on. For this case we can update the position where the cursor is going to be rendered.
For the hardware case it relies on OS cursor renderer. One of the ways to fix the issue is to update the cursor image center but it leads to many computations including that in this case the cursor is rendered as is and the game screen can be scaled by SDL.
This PR also slightly optimizes calculations in
Display::render()method andgetActiveArea()function.