Skip to content

feat(api): make more connect() params kwarg-only or positional-only #11098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(api): make more connect() params kwarg-only or positional-only #11098

wants to merge 1 commit into from

Conversation

NickCrews
Copy link
Contributor

No description provided.

@github-actions github-actions bot added impala The Apache Impala backend postgres The PostgreSQL backend sqlite The SQLite backend clickhouse The ClickHouse backend mysql The MySQL backend pyspark The Apache PySpark backend datafusion The Apache DataFusion backend bigquery The BigQuery backend duckdb The DuckDB backend polars The polars backend snowflake The Snowflake backend mssql The Microsoft SQL Server backend trino The Trino backend exasol Issues related to the exasol backend risingwave The RisingWave backend labels Apr 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

See https://github.com/ibis-project/ibis/blob/main/.releaserc.js
for the list of acceptable prefixes, eg "feat:", "fix:", "chore:", etc.

The commitlint output is:

⧗   input: API: make more connect() params kwarg-only or positional-only
✖   type must be lower-case [type-case]
✖   type must be one of [build, chore, ci, depr, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@NickCrews NickCrews changed the title API: make more connect() params kwarg-only or positional-only feat(api): make more connect() params kwarg-only or positional-only Apr 7, 2025
@cpcloud cpcloud added the breaking change Changes that introduce an API break at any level label Apr 14, 2025
@cpcloud
Copy link
Member

cpcloud commented Apr 14, 2025

+1 on this PR, but let's crank through some more non-breaking ones and cut one more release before shipping this in 11.0

@gforsyth gforsyth added this to the 11.0 milestone Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bigquery The BigQuery backend breaking change Changes that introduce an API break at any level clickhouse The ClickHouse backend datafusion The Apache DataFusion backend duckdb The DuckDB backend exasol Issues related to the exasol backend impala The Apache Impala backend mssql The Microsoft SQL Server backend mysql The MySQL backend polars The polars backend postgres The PostgreSQL backend pyspark The Apache PySpark backend risingwave The RisingWave backend snowflake The Snowflake backend sqlite The SQLite backend trino The Trino backend
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NickCrews @cpcloud @gforsyth