Skip to content

Commit b9bb3a7

Browse files
committed
feat(api): make more connect() params kwarg-only or positional-only
1 parent 20bec13 commit b9bb3a7

File tree

15 files changed

+17
-3
lines changed

15 files changed

+17
-3
lines changed

ibis/backends/bigquery/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,7 @@ def do_connect(
339339
self,
340340
project_id: str | None = None,
341341
dataset_id: str = "",
342+
*,
342343
credentials: google.auth.credentials.Credentials | None = None,
343344
application_name: str | None = None,
344345
auth_local_webserver: bool = True,

ibis/backends/clickhouse/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ def _convert_kwargs(self, kwargs):
107107

108108
def do_connect(
109109
self,
110+
*,
110111
host: str = "localhost",
111112
port: int | None = None,
112113
database: str = "default",

ibis/backends/datafusion/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def version(self):
8787
return importlib.metadata.version("datafusion")
8888

8989
def do_connect(
90-
self, config: Mapping[str, str | Path] | SessionContext | None = None
90+
self, config: Mapping[str, str | Path] | SessionContext | None = None, /
9191
) -> None:
9292
"""Create a DataFusion `Backend` for use with Ibis.
9393

ibis/backends/duckdb/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,8 @@ def version(self) -> str:
365365
def do_connect(
366366
self,
367367
database: str | Path = ":memory:",
368+
/,
369+
*,
368370
read_only: bool = False,
369371
extensions: Sequence[str] | None = None,
370372
**config: Any,

ibis/backends/exasol/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ def version(self) -> str:
5757

5858
def do_connect(
5959
self,
60+
*,
6061
user: str,
6162
password: str,
6263
host: str = "localhost",

ibis/backends/impala/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ def _from_url(self, url: ParseResult, **kwargs: Any) -> Backend:
9090

9191
def do_connect(
9292
self,
93+
*,
9394
host: str = "localhost",
9495
port: int = 21050,
9596
database: str = "default",

ibis/backends/mssql/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ def version(self) -> str:
8888

8989
def do_connect(
9090
self,
91+
*,
9192
host: str = "localhost",
9293
user: str | None = None,
9394
password: str | None = None,

ibis/backends/mysql/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ def version(self):
9191

9292
def do_connect(
9393
self,
94+
*,
9495
host: str = "localhost",
9596
user: str | None = None,
9697
password: str | None = None,

ibis/backends/polars/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def __init__(self, *args, **kwargs):
3838
self._context = pl.SQLContext()
3939

4040
def do_connect(
41-
self, tables: Mapping[str, pl.LazyFrame | pl.DataFrame] | None = None
41+
self, tables: Mapping[str, pl.LazyFrame | pl.DataFrame] | None = None, /
4242
) -> None:
4343
"""Construct a client from a dictionary of polars `LazyFrame`s and/or `DataFrame`s.
4444

ibis/backends/postgres/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ def version(self):
201201

202202
def do_connect(
203203
self,
204+
*,
204205
host: str | None = None,
205206
user: str | None = None,
206207
password: str | None = None,

ibis/backends/pyspark/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ def __init__(self, *args, **kwargs):
137137
def do_connect(
138138
self,
139139
session: SparkSession | None = None,
140+
*,
140141
mode: ConnectionMode = "batch",
141142
**kwargs,
142143
) -> None:

ibis/backends/risingwave/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -431,6 +431,7 @@ def _safe_raw_sql(self, *args, **kwargs):
431431

432432
def do_connect(
433433
self,
434+
*,
434435
host: str | None = None,
435436
user: str | None = None,
436437
password: str | None = None,

ibis/backends/snowflake/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ def _make_udf(self, name: str, defn) -> str:
239239
AS
240240
$$ {defn["source"]} $$"""
241241

242-
def do_connect(self, create_object_udfs: bool = True, **kwargs: Any):
242+
def do_connect(self, *, create_object_udfs: bool = True, **kwargs: Any):
243243
"""Connect to Snowflake.
244244
245245
Parameters

ibis/backends/sqlite/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ def version(self) -> str:
5959
def do_connect(
6060
self,
6161
database: str | Path | None = None,
62+
/,
63+
*,
6264
type_map: dict[str, str | dt.DataType] | None = None,
6365
) -> None:
6466
"""Create an Ibis client connected to a SQLite database.

ibis/backends/trino/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ def list_tables(
243243

244244
def do_connect(
245245
self,
246+
*,
246247
user: str = "user",
247248
password: str | None = None,
248249
host: str = "localhost",

0 commit comments

Comments
 (0)