Skip to content

do not set "___ADD_NEW___" value in ha-floor-picker #26102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

chrisv-dev
Copy link
Contributor

Proposed change

This PR fixes a bug, which leads to created areas not showing up in the UI (because the floor_id gets set to ___ADD_NEW___ ) as described in #25979.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chrisv-dev

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft July 7, 2025 21:26
@home-assistant
Copy link

home-assistant bot commented Jul 7, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@chrisv-dev chrisv-dev marked this pull request as ready for review July 7, 2025 21:40
@home-assistant home-assistant bot dismissed their stale review July 7, 2025 21:40

Stale

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for the fix. We also have the same issue for the area-picker.
Feel free to open another PR to fix this one too 🙂

@piitaya piitaya added this to the 2025.7 milestone Jul 8, 2025
@piitaya piitaya merged commit 2809a30 into home-assistant:dev Jul 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Areas assigned to "___ADD_NEW___" floor do not appear in UI
3 participants