feat: use k8s configMaps to mount files during solo network deploy #345

jeromy-cannon · 2024-05-31T22:11:37Z

Description

This pull request changes the following:

use k8s configMaps to mount files during solo network deploy
- apiPermissionProperties
- applicationProperties
- bootstrapProperties
- log4j2Xml
- settingTxt
add jest-expect-message so that we can add messages to expect(actual)... to expect(actual, message)...
updated node add to use new flag persistentVolumeClaims `--pvcs' to get configMaps updated for config.txt and application.properties
added nodePodName to NetworkNodeService
moved config file setup from node setup to network deploy

Related Issues

github-actions · 2024-05-31T22:15:12Z

Unit Test Results - Linux

1 files 19 suites 48s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
152 runs 152 ✅ 0 💤 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-31T22:16:34Z

Unit Test Results - Windows

1 files 19 suites 1m 36s ⏱️
126 tests 126 ✅ 0 💤 0 ❌
152 runs 152 ✅ 0 💤 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-31T22:18:44Z

E2E Relay Tests Coverage Report

1 files 1 suites 2m 45s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs 6 ✅ 0 💤 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-31T22:21:12Z

E2E Tests Coverage Report

57 tests 57 ✅ 4m 23s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-31T22:23:01Z

E2E Node PEM Stop Add Tests Coverage Report

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 45251dc.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-31T22:24:33Z

E2E Mirror Node Tests Coverage Report

1 files 1 suites 3m 47s ⏱️
12 tests 12 ✅ 0 💤 0 ❌
13 runs 13 ✅ 0 💤 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-31T22:24:47Z

E2E Node PFX Kill Add Tests Coverage Report

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 45251dc.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-31T22:25:38Z

E2E Node Local Build Tests Coverage Report

8 tests 8 ✅ 2m 44s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

jeromy-cannon · 2024-06-10T16:38:19Z

TODO, remember to update README

github-actions · 2024-08-14T16:34:57Z

E2E Node PEM Stop Tests Coverage Report

12 tests 12 ✅ 2m 41s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

github-actions · 2024-08-14T16:34:59Z

E2E Node Add Tests Coverage Report

10 tests 10 ✅ 6m 37s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

github-actions · 2024-08-14T16:42:55Z

E2E Node PFX Kill Tests Coverage Report

12 tests 12 ✅ 2m 52s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 28bd38a.

♻️ This comment has been updated with latest results.

codacy-production · 2024-08-16T16:12:47Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `aa31301`¹	✅ 91.88%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`aa31301`)	Report Missing	Report Missing	Report Missing
Head commit (`28bd38a`)	3716	3029	81.51%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#345)	160	147	91.88%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-08-16T16:14:40Z

Codecov Report

Attention: Patch coverage is 91.52542% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.21%. Comparing base (eab3340) to head (28bd38a).
Report is 9 commits behind head on main.

Files	Patch %	Lines
src/core/profile_manager.mjs	93.05%	5 Missing ⚠️
src/commands/relay.mjs	71.42%	4 Missing ⚠️
src/commands/network.mjs	83.33%	2 Missing ⚠️
src/commands/prompts.mjs	0.00%	2 Missing ⚠️
src/commands/node.mjs	98.18%	1 Missing ⚠️
test/test_util.js	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   81.40%   81.21%   -0.19%     
==========================================
  Files          35       35              
  Lines        4414     4444      +30     
  Branches      755      756       +1     
==========================================
+ Hits         3593     3609      +16     
- Misses        819      835      +16     
+ Partials        2        0       -2

Files	Coverage Δ
src/commands/base.mjs	`95.23% <100.00%> (ø)`
src/commands/flags.mjs	`95.23% <100.00%> (+0.07%)`	⬆️
src/core/account_manager.mjs	`77.77% <100.00%> (+0.52%)`	⬆️
src/core/helpers.mjs	`92.06% <100.00%> (ø)`
src/core/network_node_services.mjs	`97.67% <100.00%> (+0.11%)`	⬆️
src/core/platform_installer.mjs	`86.44% <100.00%> (-3.81%)`	⬇️
src/core/templates.mjs	`76.92% <100.00%> (-0.86%)`	⬇️
src/commands/node.mjs	`78.75% <98.18%> (-0.92%)`	⬇️
test/test_util.js	`88.67% <85.71%> (+11.55%)`	⬆️
src/commands/network.mjs	`55.55% <83.33%> (+0.73%)`	⬆️
... and 3 more

commit 45251dc Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 17:04:15 2024 +0100 revert changes in init.mjs Signed-off-by: Jeromy Cannon <[email protected]> commit 69c844d Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 15:57:02 2024 +0100 fixed unused configs test case Signed-off-by: Jeromy Cannon <[email protected]> commit ec3fc91 Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 15:45:59 2024 +0100 fixed tests, altered used/unused command options Signed-off-by: Jeromy Cannon <[email protected]> commit 3e1791d Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 14:57:25 2024 +0100 fix unit test cases Signed-off-by: Jeromy Cannon <[email protected]> commit d06b6b9 Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 14:42:11 2024 +0100 fix lint error Signed-off-by: Jeromy Cannon <[email protected]> commit 7573147 Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 14:36:48 2024 +0100 remove TODOs Signed-off-by: Jeromy Cannon <[email protected]> commit 524737a Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 14:11:26 2024 +0100 remove TODOs Signed-off-by: Jeromy Cannon <[email protected]> commit c9e5de0 Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 13:54:36 2024 +0100 moved node subtask 'Copy configuration files' into profile_manager Signed-off-by: Jeromy Cannon <[email protected]> commit b7887c0 Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 13:28:04 2024 +0100 increase test coverage Signed-off-by: Jeromy Cannon <[email protected]> commit 9aa2b3a Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 12:46:51 2024 +0100 remove NodeInfo references Signed-off-by: Jeromy Cannon <[email protected]> commit a0fae4b Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 12:43:20 2024 +0100 # TODO: bootstrap.properties is scheduled to go away, will need to delete this and related code Signed-off-by: Jeromy Cannon <[email protected]> commit b01ff4f Author: Jeromy Cannon <[email protected]> Date: Thu Jul 18 12:20:36 2024 +0100 typedef Signed-off-by: Jeromy Cannon <[email protected]> commit eae6b44 Author: Jeromy Cannon <[email protected]> Date: Wed Jul 17 22:14:52 2024 +0100 hedera app name is now set as default Signed-off-by: Jeromy Cannon <[email protected]> commit c7ce8eb Author: Jeromy Cannon <[email protected]> Date: Wed Jul 17 21:43:17 2024 +0100 fix test cases Signed-off-by: Jeromy Cannon <[email protected]> commit 9c305ca Author: Jeromy Cannon <[email protected]> Date: Wed Jul 17 19:58:22 2024 +0100 fix lint issues Signed-off-by: Jeromy Cannon <[email protected]> commit 60a364d Author: Jeromy Cannon <[email protected]> Date: Wed Jul 17 19:56:24 2024 +0100 some fixes Signed-off-by: Jeromy Cannon <[email protected]> commit a2e6186 Author: Jeromy Cannon <[email protected]> Date: Wed Jul 17 13:31:11 2024 +0100 Squashed commit of the following: commit c2342d1 Author: Jeromy Cannon <[email protected]> Date: Wed Jun 5 10:35:53 2024 +0100 add ability for a flag to be disabled from prompt Signed-off-by: Jeromy Cannon <[email protected]> commit 86fb0b1 Author: Jeromy Cannon <[email protected]> Date: Wed Jun 5 10:35:08 2024 +0100 sort flagsList and add typedef to flags.mjs Signed-off-by: Jeromy Cannon <[email protected]> commit b9abf97 Author: Jeromy Cannon <[email protected]> Date: Tue Jun 4 17:17:25 2024 +0100 TODO Signed-off-by: Jeromy Cannon <[email protected]> commit 4fafe80 Author: Jeromy Cannon <[email protected]> Date: Tue Jun 4 16:34:53 2024 +0100 added TODO Signed-off-by: Jeromy Cannon <[email protected]> commit 257ed76 Author: Jeromy Cannon <[email protected]> Date: Mon Jun 3 20:04:20 2024 +0100 saving progress Signed-off-by: Jeromy Cannon <[email protected]> commit 43ab636 Author: Jeromy Cannon <[email protected]> Date: Mon Jun 3 19:56:27 2024 +0100 restructured network.mjs to remove duplication of flags list and be easier to match up with prepare config Signed-off-by: Jeromy Cannon <[email protected]> commit 4ec2ce1 Author: Jeromy Cannon <[email protected]> Date: Mon Jun 3 18:42:00 2024 +0100 we don't need to specifically request applicationEnv, it can just be provided optionally Signed-off-by: Jeromy Cannon <[email protected]> commit d36252f Author: Jeromy Cannon <[email protected]> Date: Mon Jun 3 18:41:13 2024 +0100 added chain id and app name defaults to flags Signed-off-by: Jeromy Cannon <[email protected]> commit d21abb7 Author: Jeromy Cannon <[email protected]> Date: Fri May 31 23:09:51 2024 +0100 TODO design Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

## [0.28.0](v0.27.0...v0.28.0) (2024-08-26) ### Features * add freeze account ([#436](#436)) ([8fe5a41](8fe5a41)) * enhance node add to work with staking and dynamic address book ([#469](#469)) ([b452599](b452599)) * use k8s configMaps to mount files during solo network deploy ([#345](#345)) ([af27f16](af27f16)) ### Bug Fixes * hugo jsdoc failure ([#498](#498)) ([ff07413](ff07413)) * reduce number of account used e2e init account test ([#477](#477)) ([51d7ade](51d7ade)) * Resolve various problems to enable tests from local-node and smart-contracts to run agains solo network ([#402](#402)) ([c99d881](c99d881)) * use path.join instead of forward slashes to support Windows ([#491](#491)) ([82a5053](82a5053))

swirlds-automation · 2024-08-26T14:58:04Z

🎉 This PR is included in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon self-assigned this May 31, 2024

jeromy-cannon force-pushed the 00136-config-files-to-configmaps branch from 5f82388 to d21abb7 Compare June 3, 2024 15:12

jeromy-cannon mentioned this pull request Jun 10, 2024

Sort flags in arrays to make code changes and maintenance easier and add disablePrompt #368

Closed

jeromy-cannon force-pushed the 00136-config-files-to-configmaps branch 2 times, most recently from 0a25dc4 to 634a75c Compare July 17, 2024 12:46

jeromy-cannon changed the base branch from main to 00354-flags-refactor July 17, 2024 12:50

jeromy-cannon force-pushed the 00136-config-files-to-configmaps branch 2 times, most recently from 8ef0277 to f2e31ce Compare July 17, 2024 20:59

Base automatically changed from 00354-flags-refactor to main July 18, 2024 08:23

jeromy-cannon force-pushed the 00136-config-files-to-configmaps branch from 5d1cd48 to b01ff4f Compare July 18, 2024 11:21

jeromy-cannon force-pushed the 00136-config-files-to-configmaps branch 3 times, most recently from 5519c2a to 5216b08 Compare August 14, 2024 16:25

jeromy-cannon force-pushed the 00136-config-files-to-configmaps branch 2 times, most recently from c6b6fcc to 48b272d Compare August 16, 2024 14:15

jeromy-cannon added 16 commits August 16, 2024 17:35

add NetworkNodeServices withNodePodName

f4c4bf5

Signed-off-by: Jeromy Cannon <[email protected]>

update to use kind config yaml

f554df4

Signed-off-by: Jeromy Cannon <[email protected]>

path.join changes to support windows

0db0e93

Signed-off-by: Jeromy Cannon <[email protected]>

add NetworkNodeServices withNodePodName

e5f07d7

Signed-off-by: Jeromy Cannon <[email protected]>

set volumeclaim for testing node add

1a24536

Signed-off-by: Jeromy Cannon <[email protected]>

node add changes

99201aa

Signed-off-by: Jeromy Cannon <[email protected]>

compile errors for network.mjs

b8dcdaa

Signed-off-by: Jeromy Cannon <[email protected]>

fix copy paste error in profile_manager.mjs

1b45f0a

Signed-off-by: Jeromy Cannon <[email protected]>

progressing node add

1df98ca

Signed-off-by: Jeromy Cannon <[email protected]>

simplify chart_manager.test.mjs

07b70ed

Signed-off-by: Jeromy Cannon <[email protected]>

fix node-add.test.mjs

b469537

Signed-off-by: Jeromy Cannon <[email protected]>

opened issues, removed todo

2c6799b

Signed-off-by: Jeromy Cannon <[email protected]>

add flag for pvc

b88e527

Signed-off-by: Jeromy Cannon <[email protected]>

prep for pr review

2d7d171

Signed-off-by: Jeromy Cannon <[email protected]>

backout kind-config.yaml changes

5fc0a9c

Signed-off-by: Jeromy Cannon <[email protected]>

backout kind-config.yaml changes

28bd38a

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon force-pushed the 00136-config-files-to-configmaps branch from dc84076 to 28bd38a Compare August 16, 2024 16:36

jeromy-cannon marked this pull request as ready for review August 16, 2024 16:36

jeromy-cannon requested review from a team and leninmehedy as code owners August 16, 2024 16:36

jeromy-cannon requested review from nathanklick, JeffreyDallas and matteriben August 16, 2024 16:44

JeffreyDallas approved these changes Aug 16, 2024

View reviewed changes

jeromy-cannon merged commit af27f16 into main Aug 19, 2024
32 of 33 checks passed

jeromy-cannon deleted the 00136-config-files-to-configmaps branch August 19, 2024 09:03

swirlds-automation added the released label Aug 26, 2024

feat: use k8s configMaps to mount files during solo network deploy #345

feat: use k8s configMaps to mount files during solo network deploy #345

Uh oh!

Conversation

jeromy-cannon commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Uh oh!

github-actions bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Linux

Uh oh!

github-actions bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Windows

Uh oh!

github-actions bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Relay Tests Coverage Report

Uh oh!

github-actions bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests Coverage Report

Uh oh!

github-actions bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node PEM Stop Add Tests Coverage Report

Uh oh!

github-actions bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Mirror Node Tests Coverage Report

Uh oh!

github-actions bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node PFX Kill Add Tests Coverage Report

Uh oh!

github-actions bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node Local Build Tests Coverage Report

Uh oh!

jeromy-cannon commented Jun 10, 2024

Uh oh!

github-actions bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node PEM Stop Tests Coverage Report

Uh oh!

github-actions bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node Add Tests Coverage Report

Uh oh!

github-actions bot commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node PFX Kill Tests Coverage Report

Uh oh!

codacy-production bot commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

Uh oh!

codecov bot commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

swirlds-automation commented Aug 26, 2024

Uh oh!

Uh oh!

jeromy-cannon commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

codacy-production bot commented Aug 16, 2024 •

edited

Loading

codecov bot commented Aug 16, 2024 •

edited

Loading