TODO design

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

src/commands/node.mjs

@@ -552,6 +552,7 @@ export class NodeCommand extends BaseCommand {
             {
               title: 'Prepare config.txt for the network',
               task: async (ctx, _) => {
+                // TODO: move this to profile manager, the flags need to go to init and network commands
                 const config = ctx.config
                 const configTxtPath = `${config.stagingDir}/config.txt`
                 const template = `${constants.RESOURCES_DIR}/templates/config.template`
@@ -1311,6 +1312,7 @@ export class NodeCommand extends BaseCommand {
             {
               title: 'Prepare config.txt for the network',
               task: async (ctx, _) => {
+                // TODO: move this to profile manager, the flags need to go to init and network commands
                 const config = ctx.config
                 const configTxtPath = `${config.stagingDir}/config.txt`
                 const template = `${constants.RESOURCES_DIR}/templates/config.template`

src/core/platform_installer.mjs

@@ -177,6 +177,7 @@ export class PlatformInstaller {
     }
   }
 
+  // TODO delete this we will update profileManager.resourcesForConsensusPod to read these files and put into the values.yaml
   async copyPlatformConfigFiles (podName, stagingDir) {
     const self = this
 
@@ -270,14 +271,17 @@ export class PlatformInstaller {
 
   /**
    * Prepares config.txt file for the node
-   * @param nodeIDs node IDs
-   * @param destPath path where config.txt should be written
-   * @param releaseTag release tag e.g. v0.42.0
-   * @param template path to the confit.template file
-   * @param chainId chain ID (298 for local network)
+   * @param {string[]} nodeIDs node IDs
+   * @param {string} destPath path where config.txt should be written
+   * @param {string} releaseTag release tag e.g. v0.42.0
+   * @param {string} template path to the config.template file
+   * @param {string} chainId chain ID (298 for local network)
+   * @param {string} appName the app name (default: HederaNode.jar)
    * @returns {Promise<string[]>}
    */
   async prepareConfigTxt (nodeIDs, destPath, releaseTag, chainId = constants.HEDERA_CHAIN_ID, template = `${constants.RESOURCES_DIR}/templates/config.template`, appName = constants.HEDERA_APP_NAME) {
+    // TODO: move this to profile manager
+    // TODO: nodeIds should come from argv, it is required, it is already in profileManager.resourcesForConsensusPod
     if (!nodeIDs || nodeIDs.length === 0) throw new MissingArgumentError('list of node IDs is required')
     if (!destPath) throw new MissingArgumentError('destPath is required')
     if (!template) throw new MissingArgumentError('config templatePath is required')
@@ -294,9 +298,10 @@ export class PlatformInstaller {
     const releaseVersion = semver.parse(releaseTag, { includePrerelease: true })
 
     try {
+      // TODO we need to build the config.txt prior to deploying the network
       const networkNodeServicesMap = await this.accountManager.getNodeServiceMap(this._getNamespace())
       /** @type {string[]} */
-      const configLines = []
+      const configLines = fs.readFileSync(template, 'utf-8').split('\n')
       configLines.push(`swirld, ${chainId}`)
       configLines.push(`app, ${appName}`)
 
@@ -309,6 +314,7 @@ export class PlatformInstaller {
         const internalIP = Templates.renderFullyQualifiedNetworkPodName(this._getNamespace(), nodeId)
         const externalIP = Templates.renderFullyQualifiedNetworkSvcName(this._getNamespace(), nodeId)
 
+        // TODO yamlRoot returned from ProfileManager.resourcesForConsensusPod (called from prepareValuesForFstChart) has: { hedera.nodes.${nodeIndex}.name & hedera.nodes.${nodeIndex}.accountId }        const account = networkNodeServices.accountId
         const account = networkNodeServices.accountId
         if (releaseVersion.minor >= 40) {
           configLines.push(`address, ${nodeSeq}, ${nodeNickName}, ${nodeName}, ${nodeStakeAmount}, ${internalIP}, ${internalPort}, ${externalIP}, ${externalPort}, ${account}`)

src/core/profile_manager.mjs

@@ -145,6 +145,7 @@ export class ProfileManager {
     }
   }
 
+  // TODO need to pass through the config.releaseTag, config.chainId, and config.app
   resourcesForConsensusPod (profile, nodeIds, yamlRoot) {
     if (!profile) throw new MissingArgumentError('profile is required')
 
@@ -155,11 +156,25 @@ export class ProfileManager {
 
     // set consensus pod level resources
     for (let nodeIndex = 0; nodeIndex < nodeIds.length; nodeIndex++) {
+      // TODO here is where the nodeId is set, hedera.nodes.${nodeIndex}.name
       this._setValue(`hedera.nodes.${nodeIndex}.name`, nodeIds[nodeIndex], yamlRoot)
+      // TODO here is where the accountId is set, hedera.nodes.${nodeIndex}.accountId
       this._setValue(`hedera.nodes.${nodeIndex}.accountId`, `${realm}.${shard}.${accountId++}`, yamlRoot)
       this._setChartItems(`hedera.nodes.${nodeIndex}`, profile.consensus, yamlRoot)
     }
 
+    // TODO prepareConfigTxt then set the value
+    // TODO load the files and set the values
+    // hedera:
+    //     configMaps:
+    //         apiPermissionsProperties: ""
+    //         applicationEnv: ""
+    //         applicationProperties: ""
+    //         bootstrapProperties: ""
+    //         configTxt: ""
+    //         log4j2Xml: ""
+    //         settingsTxt: ""
+
     if (profile.consensus) {
       // set default for consensus pod
       this._setChartItems('defaults.root', profile.consensus.root, yamlRoot)
@@ -217,6 +232,8 @@ export class ProfileManager {
    * @return {Promise<string>} return the full path to the values file
    */
   prepareValuesForFstChart (profileName, applicationEnvFilePath = '') {
+    // TODO need to pass through the config.releaseTag, config.chainId, and config.app
+
     if (!profileName) throw new MissingArgumentError('profileName is required')
     const profile = this.getProfile(profileName)
 
@@ -225,6 +242,7 @@ export class ProfileManager {
 
     // generate the yaml
     const yamlRoot = {}
+    // TODO yamlRoot returned from ProfileManager.resourcesForConsensusPod (called from prepareValuesForFstChart) has: { hedera.nodes.${nodeIndex}.name & hedera.nodes.${nodeIndex}.accountId }
     this.resourcesForConsensusPod(profile, nodeIds, yamlRoot)
     this.resourcesForHaProxyPod(profile, yamlRoot)
     this.resourcesForEnvoyProxyPod(profile, yamlRoot)