Skip to content

feat: node log command also download config.txt and settings.txt #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 3, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented May 31, 2024

Description

This pull request changes the following:

  • Minor change to also download config.txt and settings.txt
  • Update setting.txt to align with latest on hedera repo
  • update how to use name space in calling getNodeLogs()

Related Issues

JeffreyDallas and others added 11 commits May 30, 2024 16:21
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners May 31, 2024 17:37
Copy link
Contributor

Unit Test Results - Windows

  1 files   19 suites   1m 56s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
149 runs  149 ✅ 0 💤 0 ❌

Results for commit a2bd978.

Copy link
Contributor

Unit Test Results - Linux

  1 files   19 suites   1m 25s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
149 runs  149 ✅ 0 💤 0 ❌

Results for commit a2bd978.

Copy link
Contributor

E2E Relay Tests Coverage Report

1 files  1 suites   3m 35s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs  6 ✅ 0 💤 0 ❌

Results for commit a2bd978.

Copy link
Contributor

E2E Node PEM Stop Add Tests Coverage Report

 1 files   1 suites   7m 45s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs  19 ✅ 0 💤 0 ❌

Results for commit a2bd978.

Copy link
Contributor

E2E Mirror Node Tests Coverage Report

11 tests   11 ✅  6m 1s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit a2bd978.

Copy link
Contributor

E2E Tests Coverage Report

55 tests   55 ✅  4m 20s ⏱️
 9 suites   0 💤
 1 files     0 ❌

Results for commit a2bd978.

Copy link
Contributor

E2E Node PFX Kill Add Tests Coverage Report

 1 files   1 suites   8m 23s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs  19 ✅ 0 💤 0 ❌

Results for commit a2bd978.

Copy link
Contributor

github-actions bot commented May 31, 2024

E2E Node Local Build Tests Coverage Report

8 tests   8 ✅  3m 7s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit a2bd978.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 0a175591 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0a17559) Report Missing Report Missing Report Missing
Head commit (a2bd978) 3410 2770 81.23%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#342) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.88%. Comparing base (720ee0d) to head (a2bd978).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   81.87%   81.88%           
=======================================
  Files          35       35           
  Lines        4060     4062    +2     
  Branches      716      638   -78     
=======================================
+ Hits         3324     3326    +2     
  Misses        736      736           
Files Coverage Δ
src/core/helpers.mjs 94.79% <100.00%> (+0.11%) ⬆️
src/commands/node.mjs 77.82% <0.00%> (ø)

Impacted file tree graph

@JeffreyDallas JeffreyDallas merged commit a8711a8 into main Jun 3, 2024
33 of 34 checks passed
@JeffreyDallas JeffreyDallas deleted the 00336-D-node-log-cmd branch June 3, 2024 12:47
swirlds-automation added a commit that referenced this pull request Jun 14, 2024
## [0.27.0](v0.26.0...v0.27.0) (2024-06-14)

### Features

* add node logs command ([#337](#337)) ([720ee0d](720ee0d))
* node log command also download config.txt and settings.txt ([#342](#342)) ([a8711a8](a8711a8))

### Bug Fixes

* update config to work with new version of hedera-json-rpc-relay ([#316](#316)) ([7974ade](7974ade))
* update default full stack chart version ([#362](#362)) ([a9254c4](a9254c4))
* update default helm chart version ([#378](#378)) ([d3e7a1a](d3e7a1a))
* update the default settings and log4j2 configuration files ([#384](#384)) ([3cad24b](3cad24b))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a node logs command to download swirlds.log and hgcaa.log
3 participants