feat: add node logs command #337

JeffreyDallas · 2024-05-30T21:30:21Z

Description

This pull request changes the following:

Add help function to download swirlds.log and hgcaa.log
Add logs command so we can use solo node logs to download logs to ~/.solo directory

Related Issues

Closes Add a node logs command to download swirlds.log and hgcaa.log #336

Signed-off-by: Jeffrey Tang <[email protected]>

github-actions · 2024-05-30T21:33:26Z

Unit Test Results - Linux

1 files 19 suites 1m 53s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
149 runs 149 ✅ 0 💤 0 ❌

Results for commit cc048a6.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-30T21:34:41Z

E2E Node PFX Kill Add Tests Coverage Report

1 files 1 suites 9m 7s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs 19 ✅ 0 💤 0 ❌

Results for commit cc048a6.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-30T21:34:51Z

E2E Node PEM Stop Add Tests Coverage Report

1 files 1 suites 7m 16s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs 19 ✅ 0 💤 0 ❌

Results for commit cc048a6.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-30T21:35:01Z

Unit Test Results - Windows

1 files 19 suites 1m 53s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
149 runs 149 ✅ 0 💤 0 ❌

Results for commit cc048a6.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-30T21:36:56Z

E2E Relay Tests Coverage Report

1 files 1 suites 2m 49s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs 6 ✅ 0 💤 0 ❌

Results for commit cc048a6.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-30T21:38:20Z

E2E Mirror Node Tests Coverage Report

11 tests 11 ✅ 5m 29s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit cc048a6.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-30T21:38:34Z

E2E Tests Coverage Report

55 tests 55 ✅ 3m 58s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit cc048a6.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-30T21:40:45Z

E2E Node Local Build Tests Coverage Report

8 tests 8 ✅ 3m 29s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit cc048a6.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <[email protected]>

codacy-production · 2024-05-30T22:06:26Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `fe727e1`¹	✅ 32.26%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`fe727e1`)	Report Missing	Report Missing	Report Missing
Head commit (`cc048a6`)	3408	2769	81.25%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#337)	31	10	32.26%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-05-30T22:06:57Z

Codecov Report

Attention: Patch coverage is 29.72973% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 81.89%. Comparing base (4f603e7) to head (cc048a6).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   82.23%   81.89%   -0.35%     
==========================================
  Files          35       35              
  Lines        4020     4060      +40     
  Branches      713      716       +3     
==========================================
+ Hits         3306     3325      +19     
- Misses        714      735      +21

Files	Coverage Δ
test/e2e/e2e_node_util.js	`88.67% <100.00%> (+0.07%)`	⬆️
src/core/helpers.mjs	`94.68% <83.33%> (-1.67%)`	⬇️
src/commands/node.mjs	`77.82% <0.00%> (-2.33%)`	⬇️

Signed-off-by: Jeffrey Tang <[email protected]>

src/core/helpers.mjs

test/e2e/e2e_node_util.js

.github/workflows/zxc-e2e-test.yaml

src/commands/node.mjs

Signed-off-by: Jeffrey Tang <[email protected]>

src/core/helpers.mjs

Signed-off-by: Jeffrey Tang <[email protected]>

## [0.27.0](v0.26.0...v0.27.0) (2024-06-14) ### Features * add node logs command ([#337](#337)) ([720ee0d](720ee0d)) * node log command also download config.txt and settings.txt ([#342](#342)) ([a8711a8](a8711a8)) ### Bug Fixes * update config to work with new version of hedera-json-rpc-relay ([#316](#316)) ([7974ade](7974ade)) * update default full stack chart version ([#362](#362)) ([a9254c4](a9254c4)) * update default helm chart version ([#378](#378)) ([d3e7a1a](d3e7a1a)) * update the default settings and log4j2 configuration files ([#384](#384)) ([3cad24b](3cad24b))

swirlds-automation · 2024-06-14T10:41:13Z

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

JeffreyDallas added 2 commits May 30, 2024 16:21

feat: add node logs command

0010581

Signed-off-by: Jeffrey Tang <[email protected]>

save

9174b7b

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas requested review from leninmehedy and a team as code owners May 30, 2024 21:30

JeffreyDallas marked this pull request as draft May 30, 2024 21:30

JeffreyDallas added 2 commits May 30, 2024 16:45

typo

9f56909

Signed-off-by: Jeffrey Tang <[email protected]>

upload everything under logs

d6f3b4a

Signed-off-by: Jeffrey Tang <[email protected]>

save

a99bdbb

Signed-off-by: Jeffrey Tang <[email protected]>

jeromy-cannon assigned JeffreyDallas May 31, 2024

JeffreyDallas requested a review from jeromy-cannon May 31, 2024 12:45

JeffreyDallas marked this pull request as ready for review May 31, 2024 12:45

JeffreyDallas requested a review from a team as a code owner May 31, 2024 12:45

Merge branch 'main' into 00336-D-node-log-cmd

9486257

jeromy-cannon reviewed May 31, 2024

View reviewed changes

src/core/helpers.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed May 31, 2024

View reviewed changes

src/core/helpers.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed May 31, 2024

View reviewed changes

src/core/helpers.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed May 31, 2024

View reviewed changes

src/core/helpers.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed May 31, 2024

View reviewed changes

test/e2e/e2e_node_util.js Outdated Show resolved Hide resolved

jeromy-cannon reviewed May 31, 2024

View reviewed changes

.github/workflows/zxc-e2e-test.yaml Show resolved Hide resolved

jeromy-cannon reviewed May 31, 2024

View reviewed changes

src/commands/node.mjs Outdated Show resolved Hide resolved

PR feedback

466b871

Signed-off-by: Jeffrey Tang <[email protected]>

jeromy-cannon reviewed May 31, 2024

View reviewed changes

src/core/helpers.mjs Outdated Show resolved Hide resolved

jeromy-cannon previously approved these changes May 31, 2024

View reviewed changes

jsdoc fix

315a721

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas dismissed jeromy-cannon’s stale review via 315a721 May 31, 2024 16:24

Merge branch 'main' into 00336-D-node-log-cmd

cc048a6

jeromy-cannon approved these changes May 31, 2024

View reviewed changes

JeffreyDallas merged commit 720ee0d into main May 31, 2024
30 of 32 checks passed

JeffreyDallas deleted the 00336-D-node-log-cmd branch May 31, 2024 17:19

swirlds-automation added the released label Jun 14, 2024

feat: add node logs command #337

feat: add node logs command #337

Uh oh!

Conversation

JeffreyDallas commented May 30, 2024

Description

Related Issues

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Linux

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node PFX Kill Add Tests Coverage Report

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node PEM Stop Add Tests Coverage Report

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Windows

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Relay Tests Coverage Report

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Mirror Node Tests Coverage Report

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests Coverage Report

Uh oh!

github-actions bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node Local Build Tests Coverage Report

Uh oh!

codacy-production bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

Uh oh!

codecov bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

swirlds-automation commented Jun 14, 2024

Uh oh!

Uh oh!

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

codacy-production bot commented May 30, 2024 •

edited

Loading

codecov bot commented May 30, 2024 •

edited

Loading