Skip to content

fix: update Hedera platform version to v0.60.1 in version.ts and v0.59.5 in version-test.ts, bumped mirror node to v0.129.1 #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix: update Hedera platform version to v0.60.1 in version.ts and v0.59.5 in version-test.ts, bumped mirror node to v0.129.1 #1879

wants to merge 15 commits into from
+3 −3

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Apr 22, 2025 •
edited
Loading

Description

This pull request changes the following:

  • update Hedera platform version to v0.60.1 in version.ts and v0.59.5 in version-test.ts
  • bumped mirror node to v0.129.1

Related Issues

  • Closes #
  • Related to #

Pull request (PR) checklist

  • This PR added tests (unit, integration, and/or end-to-end)
  • This PR updated documentation
  • This PR added no TODOs or commented out code
  • This PR has no breaking changes
  • Any technical debt has been documented as a separate issue and linked to this PR
  • Any package.json changes have been explained to and approved by a repository manager
  • All related issues have been linked to this PR
  • All changes in this PR are included in the description
  • When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

  • This PR added unit tests
  • This PR added integration/end-to-end tests
  • These changes required manual testing that is documented below
  • Anything not tested is documented

The following manual testing was done:

  • TBD

The following was not tested:

  • TBD
Commit message guidelines We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:
  1. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
  2. The title is prefixed with one of the following:
Prefix Description Semantic Version Update Captured in Release Notes
feat: a new feature MINOR Yes
fix: a bug fix PATCH Yes
perf: performance PATCH Yes
refactor: code change that isn't feature or fix none No
test: adding missing tests none No
docs: changes to documentation none Yes
build: changes to build process none No
ci: changes to CI configuration none No
style: formatting, missing semi-colons, etc none No
chore: updating grunt tasks etc; no production code change none No

@jeromy-cannon jeromy-cannon self-assigned this Apr 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025 •
edited
Loading

Unit Test Results - Linux

32 tests  ±0   32 ✅ ±0   0s ⏱️ ±0s
16 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 845a7bb. ± Comparison against base commit fdb0a2a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   85 suites  ±0   3s ⏱️ -2s
360 tests ±0  360 ✅ ±0  0 💤 ±0  0 ❌ ±0 
365 runs  ±0  365 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 845a7bb. ± Comparison against base commit fdb0a2a.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon added the Blocked Further development work is blocked by other item label May 6, 2025
@jeromy-cannon jeromy-cannon force-pushed the v0-62-0-hedera-test branch from eafe9f0 to 562ca68 Compare May 7, 2025 15:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

E2E Test Report

 18 files  124 suites   2h 6m 49s ⏱️
322 tests 322 ✅ 0 💤 0 ❌
337 runs  337 ✅ 0 💤 0 ❌

Results for commit 845a7bb.

♻️ This comment has been updated with latest results.

@JeffreyDallas
Copy link
Contributor

changed to version v0.62.0-main-0cba1a3e, smart contract test passed.
but node add and node delete would not become ACTIVE after upgrade

@JeffreyDallas
try 61.2
db817b2 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
save
d49f1cf 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
update
f82dd22 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
Merge branch 'main' into v0-62-0-hedera-test
b17f520 
Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	version.ts
@JeffreyDallas
cherry pick 0.62 version
a725e3f 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
save
6ef69b1 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
smoke test use lower version
811d796 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
Copy link
Contributor

version v0.62.0-main-0cba1a3e did not work, node add/delete/update test fail with node could not become ACTIVE after restart.

Maybe we could bump to v0.62.1 but for relay and smart contract test, keep it `v0.61.41 temporarily.

@JeffreyDallas JeffreyDallas marked this pull request as ready for review May 9, 2025 19:04
@JeffreyDallas JeffreyDallas requested review from a team as code owners May 9, 2025 19:04
@JeffreyDallas
save
b37155a 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas added PR: Needs Team Approval A pull request that needs review from a team member. and removed Blocked Further development work is blocked by other item labels May 9, 2025
instamenta
instamenta previously approved these changes May 12, 2025
View reviewed changes
@jeromy-cannon jeromy-cannon added the Blocked Further development work is blocked by other item label May 13, 2025
@jeromy-cannon jeromy-cannon removed the PR: Needs Team Approval A pull request that needs review from a team member. label May 13, 2025
@jeromy-cannon
fix: update Hedera platform version to v0.60.1 and mirror node versio…
df20389 
…n to v0.129.1 in version.ts; adjust test version to v0.59.5 in version-test.ts

Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon removed the Blocked Further development work is blocked by other item label May 19, 2025
@jeromy-cannon jeromy-cannon changed the title fix: update Hedera platform version to v0.62.0 in version.ts and version-test.ts fix: update Hedera platform version to v0.60.1 in version.ts and v0.59.5 in version-test.ts, bumped mirror node to v0.129.1 May 19, 2025
@instamenta instamenta self-requested a review May 19, 2025 18:09
instamenta
instamenta previously approved these changes May 19, 2025
View reviewed changes
@codacy-production Codacy Production
Copy link

codacy-production bot commented May 19, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for fdb0a2a1 ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fdb0a2a) Report Missing Report Missing Report Missing
Head commit (845a7bb) 36215 17251 47.63%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1879) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffreyDallas JeffreyDallas JeffreyDallas approved these changes

@instamenta instamenta instamenta left review comments

@andrewb1269hg andrewb1269hg Awaiting requested review from andrewb1269hg andrewb1269hg was automatically assigned from hiero-ledger/github-maintainers

Assignees

@jeromy-cannon jeromy-cannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromy-cannon @JeffreyDallas @instamenta