Skip to content

chore: enhance diagnostic information in logs and cli output #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

nathanklick
Copy link
Contributor

@nathanklick nathanklick commented Feb 18, 2025

Description

This pull request changes the following:

  • Adds additional information to user output

@nathanklick nathanklick self-assigned this Feb 18, 2025
@nathanklick nathanklick requested review from leninmehedy and a team as code owners February 18, 2025 15:20
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   62 suites  ±0   3s ⏱️ -1s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 501c5eb. ± Comparison against base commit eacdf1f.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   62 suites  ±0   4s ⏱️ -1s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 501c5eb. ± Comparison against base commit eacdf1f.

Copy link
Contributor

github-actions bot commented Feb 18, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 37m 19s ⏱️ +58s
272 tests ±0  272 ✅ ±0  0 💤 ±0  0 ❌ ±0 
287 runs  ±0  287 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 501c5eb. ± Comparison against base commit eacdf1f.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (eacdf1f) to head (501c5eb).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
src/core/kube/resources/nested_resource_ref.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
+ Coverage   83.72%   83.74%   +0.01%     
==========================================
  Files         132      132              
  Lines       25475    25475              
  Branches     2435     1808     -627     
==========================================
+ Hits        21330    21334       +4     
- Misses       4001     4056      +55     
+ Partials      144       85      -59     
Files with missing lines Coverage Δ
src/commands/node/tasks.ts 93.69% <100.00%> (+0.10%) ⬆️
src/core/kube/resources/resource_ref.ts 78.94% <100.00%> (+5.26%) ⬆️
src/core/platform_installer.ts 90.21% <100.00%> (ø)
src/core/kube/resources/nested_resource_ref.ts 73.68% <0.00%> (ø)

... and 44 files with indirect coverage changes

Impacted file tree graph

@nathanklick nathanklick merged commit d0740a2 into main Feb 19, 2025
40 of 41 checks passed
@nathanklick nathanklick deleted the charlie-deployment-fixes-subset-1 branch February 19, 2025 18:11
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants