Skip to content

fix: resolve issues discovered during charlie sphere staging deployment testing #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

fix: resolve issues discovered during charlie sphere staging deployment testing #1423

wants to merge 10 commits into from

Conversation

nathanklick
Copy link
Contributor

@nathanklick nathanklick commented Feb 17, 2025 •
edited
Loading

Description

This pull request changes the following:

  • Fixes issues with node staking
  • Fixes issues with node activeness checks
  • Fixes internal IP handling for the 0.58.5 release
  • Improves several error messages and user output

@nathanklick
chore: add context diagnostics to fetch platform software
f831a65 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick
chore: disable concurrent fetching
7d7393f 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick
fix: resolve copyFiles failure due to lack of context information
b5812d2 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick
chore: minor tweaks
c1ce6cf 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick
fix: use better internal IPs for 0.58.5+
24c0ac3 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick
fix: increase number of attempts to wait for active nodes
962487b 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick
fix: ensure network active check supports multi-cluster deployments
269a0ef 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick
chore: ensure staking updates support multi-cluster deployments
1d0bdf9 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick
fix: additional staking fixes
53a7fa9 
Signed-off-by: Nathan Klick <[email protected]>
@nathanklick nathanklick requested review from leninmehedy and a team as code owners February 17, 2025 18:03
@nathanklick nathanklick self-assigned this Feb 17, 2025
@nathanklick nathanklick added the P0 An issue impacting production environments or impacting multiple releases or multiple individuals. label Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

Unit Test Results - Linux

  1 files  ±0   62 suites  ±0   2s ⏱️ ±0s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e60db0a. ± Comparison against base commit eacdf1f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   62 suites  ±0   3s ⏱️ -2s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e60db0a. ± Comparison against base commit eacdf1f.

♻️ This comment has been updated with latest results.

instamenta
instamenta previously approved these changes Feb 17, 2025
View reviewed changes
@nathanklick
fix: make mirror node work
e60db0a 
Signed-off-by: Nathan Klick <[email protected]>
leninmehedy
leninmehedy reviewed Feb 18, 2025
View reviewed changes
@instamenta instamenta mentioned this pull request Feb 18, 2025
Merged
@nathanklick
Copy link
Contributor Author

Superseded by:

@nathanklick nathanklick deleted the charlie-deployment-fixes branch February 24, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leninmehedy leninmehedy leninmehedy left review comments

@instamenta instamenta instamenta left review comments

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon

Assignees

@nathanklick nathanklick

Labels
P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanklick @leninmehedy @instamenta