K6 test improvement

tools/k6/src/rest/libex/parameters.js

@@ -122,6 +122,55 @@
   }
 );
 
+const computeAccountWithCryptoAllowanceParameters = wrapComputeParametersFunc(
+  ['DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE', 'DEFAULT_SPENDER_ID_CRYPTO_ALLOWANCE'],
+  () => {
+    let accountsPath = `${baseUrlPrefix}/accounts?account.id=gt:${__ENV.DEFAULT_START_ACCOUNT}&balance=false&order=asc&limit=100`;
+    const candidate = {cryptoAllowances: []};
+    let totalAccounts = 0;
+
+    while (accountsPath && totalAccounts < 100000) {
+      const {
+        accounts,
+        links: {next},
+      } = getValidResponse(accountsPath, null, http.get);
+      accountsPath = restUrlFromNext(next);
+
+      for (const {account} of accounts) {
+        const cryptoAllowancesPath = `${baseUrlPrefix}/accounts/${account}/allowances/crypto?limit=25`;
+        const cryptoAllowances = getEntities(cryptoAllowancesPath, allowanceListName);
+
+        if (cryptoAllowances.length > candidate.cryptoAllowances.length) {
+          candidate.account = account;
+          candidate.cryptoAllowances = cryptoAllowances;
+        }
+
+        if (cryptoAllowances.length >= 25) {
+          console.info(`Found account ${account} with ${cryptoAllowances.length} crypto allowances`);
+          return {
+            DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE: account,
+            DEFAULT_SPENDER_ID_CRYPTO_ALLOWANCE: cryptoAllowances[0].spender,
+          };
+        }
+      }
+
+      totalAccounts += accounts.length;
+    }
+
+    if (candidate.length > 0) {
+      console.warn(
+        `Fallback to account ${candidate.account} with ${candidate.cryptoAllowances.length} crypto allowances`
+      );
+      return {
+        DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE: candidate.account,
+        DEFAULT_SPENDER_ID_CRYPTO_ALLOWANCE: candidate.cryptoAllowances[0].spender,
+      };
+    }
+
+    throw new Error('It was not possible to find an account with with significant number of crypto allowances.');
+  }
+);
+
 const computeAccountWithNftsParameters = wrapComputeParametersFunc(['DEFAULT_ACCOUNT_ID_NFTS'], () => {
   const candidate = {balance: 0};
   let tokensPath = `${baseUrlPrefix}/tokens?type=NON_FUNGIBLE_UNIQUE&limit=100&order=asc`;
@@ -197,7 +246,7 @@
       return {DEFAULT_ACCOUNT_ID_TOKEN_ALLOWANCE: candidate.account};
     }
 
-    throw new Error('It was not possible to find an account with with significant number of allowance tokens.');
+    throw new Error('It was not possible to find an account with with significant number of token allowances.');
   }
 );
 
@@ -345,6 +394,7 @@
 
 const allHandlers = [
   computeAccountParameters,
+  computeAccountWithCryptoAllowanceParameters,
   computeAccountWithNftsParameters,
   computeAccountWithTokenAllowanceParameters,
   computeAccountWithTokenParameters,

tools/k6/src/rest/test/accountsCryptoAllowance.js

@@ -2,12 +2,13 @@
 
 import http from 'k6/http';
 
-import {isSuccess, RestTestScenarioBuilder} from '../libex/common.js';
-import {resultListName} from '../libex/constants.js';
+import {isValidListResponse, RestTestScenarioBuilder} from '../libex/common.js';
+import {allowanceListName} from '../libex/constants.js';
 
 const urlTag = '/accounts/{id}/allowances/crypto';
 
-const getUrl = (testParameters) => `/accounts/${testParameters['DEFAULT_ACCOUNT_ID']}/allowances/crypto`;
+const getUrl = (testParameters) =>
+  `/accounts/${testParameters['DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE']}/allowances/crypto`;
 
 const {options, run, setup} = new RestTestScenarioBuilder()
   .name('accountCryptoAllowancesResults') // use unique scenario name among all tests
@@ -16,8 +17,8 @@ const {options, run, setup} = new RestTestScenarioBuilder()
     const url = `${testParameters['BASE_URL_PREFIX']}${getUrl(testParameters)}`;
     return http.get(url);
   })
-  .requiredParameters('DEFAULT_ACCOUNT_ID')
-  .check('Account crypto allowances results OK', (r) => isSuccess(r, resultListName))
+  .requiredParameters('DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE')
+  .check('Account crypto allowances results OK', (r) => isValidListResponse(r, allowanceListName))
   .build();
 
 export {getUrl, options, run, setup};

tools/k6/src/rest/test/accountsCryptoAllowanceSpender.js

@@ -2,11 +2,13 @@
 
 import http from 'k6/http';
 
-import {isSuccess, RestTestScenarioBuilder} from '../libex/common.js';
+import {isValidListResponse, RestTestScenarioBuilder} from '../libex/common.js';
+import {allowanceListName} from '../libex/constants.js';
 
 const urlTag = '/accounts/{id}/allowances/crypto';
 
-const getUrl = (testParameters) => `/accounts/${testParameters['DEFAULT_ACCOUNT_ID']}/allowances/crypto?spender.id=98`;
+const getUrl = (testParameters) =>
+  `/accounts/${testParameters['DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE']}/allowances/crypto?spender.id=${testParameters['DEFAULT_SPENDER_ID_CRYPTO_ALLOWANCE']}`;
 
 const {options, run, setup} = new RestTestScenarioBuilder()
   .name('accountCryptoAllowancesResultsSpender') // use unique scenario name among all tests
@@ -15,8 +17,8 @@ const {options, run, setup} = new RestTestScenarioBuilder()
     const url = `${testParameters['BASE_URL_PREFIX']}${getUrl(testParameters)}`;
     return http.get(url);
   })
-  .requiredParameters('DEFAULT_ACCOUNT_ID')
-  .check('Account crypto allowances for spender results OK', (r) => isSuccess(r))
+  .requiredParameters('DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE', 'DEFAULT_SPENDER_ID_CRYPTO_ALLOWANCE')
+  .check('Account crypto allowances for spender results OK', (r) => isValidListResponse(r, allowanceListName))
   .build();
 
 export {getUrl, options, run, setup};

tools/k6/src/web3/test/common.js

@@ -3,8 +3,19 @@
 import {check, sleep} from 'k6';
 import {vu} from 'k6/execution';
 import http from 'k6/http';
+import {SharedArray} from 'k6/data';
+
 import * as utils from '../../lib/common.js';
 
+const defaultVuData = {
+  block: '',
+  data: '',
+  to: '',
+  gas: 0,
+  from: '',
+  value: 0,
+  sleep: 0,
+};
 const resultField = 'result';
 
 function isNonErrorResponse(response) {
@@ -29,6 +40,12 @@
     },
   });
 
+const loadVuDataOrDefault = (filepath, key) =>
+  new SharedArray(key, () => {
+    const data = JSON.parse(open(filepath));
+    return key in data ? data[key] : [];
+  });
+
 function ContractCallTestScenarioBuilder() {
   this._args = null;
   this._name = null;
@@ -66,7 +83,7 @@
         } else {
           const {_vuData: vuData} = that;
           const data = vuData
-            ? Object.assign({}, vuData[vu.idInTest % vuData.length])
+            ? Object.assign({}, defaultVuData, vuData[vu.idInTest % vuData.length])
             : {
                 block: that._block,
                 data: that._data,
@@ -173,4 +190,4 @@
   return this;
 }
 
-export {isNonErrorResponse, jsonPost, ContractCallTestScenarioBuilder};
+export {isNonErrorResponse, jsonPost, loadVuDataOrDefault, ContractCallTestScenarioBuilder};

tools/k6/src/web3/test/commonContractCallEstimateTemplate.js

@@ -1,16 +1,13 @@
 // SPDX-License-Identifier: Apache-2.0
 
-import {SharedArray} from 'k6/data';
-import {ContractCallTestScenarioBuilder} from './common.js';
+import {loadVuDataOrDefault, ContractCallTestScenarioBuilder} from './common.js';
 
 function ContractCallEstimateTestTemplate(key) {
-  const data = new SharedArray(key, () => {
-    return JSON.parse(open('./resources/estimate.json'))[key];
-  });
-
-  const {options, run} = new ContractCallTestScenarioBuilder().name(key).estimate(true).vuData(data).build();
-
-  return {options, run};
+  return new ContractCallTestScenarioBuilder()
+    .name(key)
+    .estimate(true)
+    .vuData(loadVuDataOrDefault('./resources/estimate.json', key))
+    .build();
 }
 
 export {ContractCallEstimateTestTemplate};

tools/k6/src/web3/test/commonPrecompileModificationFunctionsTemplate.js

@@ -1,20 +1,13 @@
 // SPDX-License-Identifier: Apache-2.0
 
-import {SharedArray} from 'k6/data';
-import {ContractCallTestScenarioBuilder} from './common.js';
+import {loadVuDataOrDefault, ContractCallTestScenarioBuilder} from './common.js';
 
 function PrecompileModificationTestTemplate(key, shouldRevert) {
-  const data = new SharedArray(key, () => {
-    return JSON.parse(open('../resources/modificationFunctions.json'))[key];
-  });
-
-  const {options, run} = new ContractCallTestScenarioBuilder()
+  return new ContractCallTestScenarioBuilder()
     .name(key)
-    .vuData(data)
+    .vuData(loadVuDataOrDefault('../resources/modificationFunctions.json', key))
     .shouldRevert(shouldRevert)
     .build();
-
-  return {options, run};
 }
 
 export {PrecompileModificationTestTemplate};