-
Notifications
You must be signed in to change notification settings - Fork 122
K6 test improvement #11505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
K6 test improvement #11505
Conversation
with default Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Signed-off-by: Xin Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR improves some k6 test cases
DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE
andDEFAULT_SPENDER_ID_CRYPTO_ALLOWANCE
for cryptoAllowance test casesRelated issue(s):
Fixes #11419
Notes for reviewer:
will create accounts and crypto allowances, then set the values for the new env var in a separate PR for deploy branch.
Checklist