Skip to content

K6 test improvement #11505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xin-hedera
Copy link
Contributor

Description:

This PR improves some k6 test cases

  • Add DEFAULT_ACCOUNT_ID_CRYPTO_ALLOWANCE and DEFAULT_SPENDER_ID_CRYPTO_ALLOWANCE for cryptoAllowance test cases
  • Move web3 estimate and modification test json data default to code
  • Add fallback default for json vu data loading

Related issue(s):

Fixes #11419

Notes for reviewer:

will create accounts and crypto allowances, then set the values for the new env var in a separate PR for deploy branch.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@xin-hedera xin-hedera requested a review from a team as a code owner July 2, 2025 17:03
@xin-hedera xin-hedera requested a review from nirbosl July 2, 2025 17:03
@xin-hedera xin-hedera linked an issue Jul 2, 2025 that may be closed by this pull request
@xin-hedera xin-hedera self-assigned this Jul 2, 2025
@xin-hedera xin-hedera added enhancement Type: New feature performance labels Jul 2, 2025
@xin-hedera xin-hedera added this to the 0.134.0 milestone Jul 2, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jul 2, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@xin-hedera xin-hedera changed the title k6 test improvement K6 test improvement Jul 2, 2025
Copy link

codacy-production bot commented Jul 2, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b06f49b1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b06f49b) Report Missing Report Missing Report Missing
Head commit (29be44b) 59355 36152 60.91%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11505) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Signed-off-by: Xin Li <[email protected]>
Copy link
Contributor

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a separate account for k6 crypto allowance test
3 participants