Skip to content

Nima: MicroMeter now contains Nima and SE integration #7090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2023

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Jun 26, 2023

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 26, 2023
@jbescos jbescos force-pushed the issue5396_4 branch 4 times, most recently from 563f7eb to eedac63 Compare June 26, 2023 15:26
jbescos and others added 3 commits June 26, 2023 17:26
- Split startServer into setupRouting to re-use in @setupServer in test
- Fix GreetService to next the request
- Rename methods and classes to remove "nima" from the name and align a little bit with 3.x
@jbescos jbescos force-pushed the issue5396_4 branch 6 times, most recently from eb29952 to 1493a19 Compare June 27, 2023 06:18
jbescos added 2 commits June 27, 2023 08:18
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@tomas-langer tomas-langer requested a review from tjquinno June 27, 2023 12:37
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a very quick look the changes LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants