Skip to content

Commit eb29952

Browse files
committed
Enable some tests
Signed-off-by: Jorge Bescos Gascon <[email protected]>
1 parent 6b937ec commit eb29952

File tree

5 files changed

+9
-13
lines changed

5 files changed

+9
-13
lines changed

examples/integrations/micrometer/se/src/main/java/io/helidon/examples/micrometer/se/Main.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import io.helidon.integrations.micrometer.MicrometerFeature;
2121
import io.helidon.logging.common.LogConfig;
2222
import io.helidon.nima.webserver.WebServer;
23+
import io.helidon.nima.webserver.WebServer.Builder;
2324
import io.helidon.nima.webserver.http.HttpRouting;
2425

2526
import io.micrometer.core.instrument.Counter;
@@ -59,11 +60,10 @@ static WebServer startServer() {
5960
// By default, this will pick up application.yaml from the classpath
6061
Config config = Config.create();
6162

62-
WebServer server = WebServer.builder()
63+
Builder builder = WebServer.builder()
6364
.config(config.get("server"))
64-
.routing(r -> setupRouting(r, config))
65-
.build()
66-
.start();
65+
.routing(r -> setupRouting(r, config));
66+
WebServer server = builder.build().start();
6767

6868
System.out.println("WEB server is up! http://localhost:" + server.port() + "/greet");
6969
return server;

examples/integrations/micrometer/se/src/test/java/io/helidon/examples/micrometer/se/MainTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import io.helidon.nima.testing.junit5.webserver.SetUpServer;
2424
import io.helidon.nima.webclient.http1.Http1Client;
2525
import io.helidon.nima.webclient.http1.Http1ClientResponse;
26-
import io.helidon.nima.webserver.WebServer;
26+
import io.helidon.nima.webserver.WebServer.Builder;
2727

2828
import jakarta.json.Json;
2929
import jakarta.json.JsonBuilderFactory;
@@ -61,7 +61,7 @@ public MainTest(Http1Client client) {
6161
}
6262

6363
@SetUpServer
64-
public static void setup(WebServer.Builder builder) {
64+
public static void setup(Builder builder) {
6565
builder.routing(r -> Main.setupRouting(r, Config.create()));
6666
}
6767

integrations/micrometer/micrometer/src/test/java/io/helidon/integrations/micrometer/MicrometerEndpointTests.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import io.helidon.nima.webserver.WebServer;
2828

2929
import org.hamcrest.MatcherAssert;
30-
import org.junit.jupiter.api.Disabled;
3130
import org.junit.jupiter.api.Test;
3231

3332
public class MicrometerEndpointTests {
@@ -36,13 +35,11 @@ public class MicrometerEndpointTests {
3635

3736

3837
@Test
39-
@Disabled("406 Not Acceptable")
4038
public void testDefaultEndpoint() throws ExecutionException, InterruptedException {
4139
runTest(MicrometerFeature.DEFAULT_CONTEXT, MicrometerFeature::create);
4240
}
4341

4442
@Test
45-
@Disabled("406 Not Acceptable")
4643
public void testExplicitEndpointWithDefaultBuiltInRegistryViaConfig() throws ExecutionException, InterruptedException {
4744
String context = "/aa";
4845
runTest(context, () -> MicrometerFeature.builder()

integrations/micrometer/micrometer/src/test/java/io/helidon/integrations/micrometer/MicrometerSimplePrometheusTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
import io.helidon.common.http.Http;
2727
import io.helidon.common.http.Http.Header;
28+
import io.helidon.common.http.HttpMediaType;
2829
import io.helidon.common.media.type.MediaTypes;
2930
import io.helidon.nima.webclient.WebClient;
3031
import io.helidon.nima.webclient.http1.Http1Client;
@@ -38,7 +39,6 @@
3839
import io.micrometer.prometheus.PrometheusMeterRegistry;
3940
import org.junit.jupiter.api.BeforeAll;
4041
import org.junit.jupiter.api.BeforeEach;
41-
import org.junit.jupiter.api.Disabled;
4242
import org.junit.jupiter.api.Test;
4343

4444
public class MicrometerSimplePrometheusTest {
@@ -83,13 +83,12 @@ void prepTest() {
8383
}
8484

8585
@Test
86-
@Disabled("Cannot parse media type: TEXT_PLAIN")
8786
public void checkViaMediaType() throws ExecutionException, InterruptedException {
8887
timer1.record(2L, TimeUnit.SECONDS);
8988
counter1.increment(3);
9089
gauge1.set(4);
9190
Http1ClientResponse response = webClient.get()
92-
.header(Header.ACCEPT, MediaTypes.TEXT_PLAIN.toString())
91+
.header(Header.ACCEPT, HttpMediaType.TEXT_PLAIN.toString())
9392
.path("/micrometer")
9493
.request();
9594

nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/WebServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ default void reloadTls(Tls tls) {
153153
/**
154154
* Fluent API builder for {@link WebServer}.
155155
*/
156-
class Builder implements io.helidon.common.Builder<Builder, WebServer>, Router.RouterBuilder<Builder> {
156+
public static class Builder implements io.helidon.common.Builder<Builder, WebServer>, Router.RouterBuilder<Builder> {
157157

158158
private static final AtomicInteger WEBSERVER_COUNTER = new AtomicInteger(1);
159159

0 commit comments

Comments
 (0)