Skip to content

Backport 1.19.x: UI: Add auth tests #30103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Mar 28, 2025

Description

✅ enterprise passed
Manual backport of #30033 to hopefully address test flakiness due to use of later() from @ember/runloop

This test in particular:

  Acceptance | oidc auth method: it prompts mfa if configured: Chrome 134.0
Test took longer than 60000ms; test timed out. 
More information has been printed to the console. Please use that information to help in debugging.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.19.1 milestone Mar 28, 2025
@hellobontempo hellobontempo requested a review from a team as a code owner March 28, 2025 20:13
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 28, 2025
Copy link

Build Results:
All builds succeeded! ✅

emoncuso
emoncuso previously approved these changes Mar 28, 2025
Copy link

github-actions bot commented Mar 28, 2025

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo merged commit f8fd17d into release/1.19.x Mar 28, 2025
26 checks passed
@hellobontempo hellobontempo deleted the backport-30033-auth-test-renovation branch March 28, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants