UI: Add auth tests #30033
Merged
UI: Add auth tests #30033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Mar 26, 2025
| return render(hbs` | ||
| <Auth::LoginForm |
There was a problem hiding this comment.
updated to be the correct component and separated into Auth::Page and Auth::LoginForm tests
|
Build Results: |
|
CI Results: |
drivera258
approved these changes
Mar 28, 2025
emoncuso
approved these changes
Mar 28, 2025
6 tasks
6 tasks
drivera258
pushed a commit
that referenced
this pull request
Mar 31, 2025
* rename page test to login form * add username/password tests to auth page test * add github and generalize tests * finish standard auth types for page test * add tests for onNamespaceInput * fix accessibility violation * add oidc provider qp test * move helper into test * move destructured arg * address oidc auth method flakiness...maybe? * cleanup unused fake window methods * add comment why... * fix diff * fix header * finish mfa acceptance tests move mfa selectors to folder
hellobontempo
added a commit
that referenced
this pull request
May 21, 2025
* rename page test to login form * add username/password tests to auth page test * add github and generalize tests * finish standard auth types for page test * add tests for onNamespaceInput * fix accessibility violation * add oidc provider qp test * move helper into test * move destructured arg * address oidc auth method flakiness...maybe? * cleanup unused fake window methods * add comment why... * fix diff * fix header * finish mfa acceptance tests move mfa selectors to folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds out auth tests in preparation for impending refactor, paying special attention to MFA + SSO workflows. No user facing changes except a small accessibility fix.
Auth::Page(previously theauth/page-testfile was testing theAuth::LoginFormcomponent)Auth::LoginFormto aptly named filelaterwithsetTimeoutreduces flakiness I'll backport that change.✅ enterprise tests
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.