[Enhancement]: aws_db_instance: Database Performance Insights Advanced Mode

[luchees]

Description

Description

Already implemented in the provider for rds_cluster but not yet for aws_db_instance
#40393

Affected Resource(s) and/or Data Source(s)

aws_rds_instance

Potential Terraform Configuration

# before
resource "aws_db_instance" "example" {
  performance_insights_enabled = true
  ...
}

# after
resource "aws_db_instance" "example" {
  performance_insights_enabled = true
  ...
  performance_insights_mode = "advanced"
}

References

No response

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[stefanfreitag]

Hi @luchees,
we would be also interested in using this feature. Did you have a chance to look into the issue? Please let me know if a helping hand is needed.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[stefanfreitag]

Hi @luchees , hi @ewbankkit,

thanks for the pull request and also the review 👍
Yesterday I looked into an issue related to the same functionality, but for rds cluster instead of a db instance.
Here is the link to issue: #41792

I had a (very brief) look into the resource update implementation as well as the test code in the linked pull request #41828.
In my opinion, we are facing the same issue here: when only two out of the three values (database insights, performance insights enabled, performance insights retention in days) change, then the update will fail.

Happy to verify this assumption tomorrow - also happy to hear your thoughts on this.

[luchees]

hi @stefanfreitag
Thanks for noticing and let me know your findings.
I want to look into that as an improvement. But I could get some help for running the acceptance tests. I'm unable to run them.

Best regards,
Lucas

[github-actions]

This functionality has been released in v5.92.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!