-
Notifications
You must be signed in to change notification settings - Fork 103
fix: introduce sticky inputs section #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a good start, but I'd imagine it a little differently - when the user starts scrolling down, we can collapse the top navigation bar, hide the title and give more room to the actual map.
what do you think?
src/App.scss
Outdated
} | ||
|
||
.height-725 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use more meaningful class-names / selectors?
for example, .map-container .position-stiky-header
src/pages/singleLineMap/index.tsx
Outdated
<div className="position-stiky-header"> | ||
<Typography className="page-title" variant="h4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using the same element?
<div className="position-stiky-header"> | |
<Typography className="page-title" variant="h4"> | |
<Typography className="page-title position-sticky-header" variant="h4"> |
Do you have tailwind installed in the app or not? |
I'm not sure if I'll have the capacity, but feel free to bring that to the f2f meeting |
I think hiding the top navigation bar would make sense in all pages. wdyt? |
I would simply adjust the map height so it will fill the screen without covering the title, navigation bars, etc. There is an option for the map to be displayed as a full page if the user wishes. How do you feel about this? |
I don't know - some users have short screens |
also, the fullscreen button is very buggy in most of the screens |
3015772
to
2915a58
Compare
Description
I have defined the headers in the time map, single-line-map and single-vehicle-map headers to a css stiky headers
resolving issue: #1059